diff --git a/.github/workflows/db2.yaml b/.github/workflows/db2.yaml index 0a9bf56d3c..9673dcb737 100644 --- a/.github/workflows/db2.yaml +++ b/.github/workflows/db2.yaml @@ -29,9 +29,10 @@ concurrency: permissions: contents: read +# Pin Ubuntu 24.04. ubuntu-latest now resolves to 26.04. jobs: db2-test: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 25 env: PYTEST_XDIST_AUTO_NUM_WORKERS: 2 diff --git a/.github/workflows/dco.yml b/.github/workflows/dco.yml index a1c4e07300..47b5035156 100644 --- a/.github/workflows/dco.yml +++ b/.github/workflows/dco.yml @@ -1,9 +1,10 @@ name: Sanity check on: [pull_request] +# Pin Ubuntu 24.04. ubuntu-latest now resolves to 26.04. jobs: commits_check_job: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 name: Commits Check steps: - name: Get PR Commits diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 9c941adf9a..c4a98586cf 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -10,9 +10,11 @@ concurrency: cancel-in-progress: true permissions: contents: read +# ubuntu-latest is Ubuntu 26.04. That image drops Python 3.9, installs OpenJDK 25 +# (Spark/Hadoop calls the removed Subject.getSubject), and has no Playwright Chromium. jobs: changes: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 outputs: python: ${{ steps.filter.outputs.python }} client: ${{ steps.filter.outputs.client }} @@ -50,7 +52,7 @@ jobs: if: needs.changes.outputs.python == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main' - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 env: UV: '1' steps: @@ -76,7 +78,7 @@ jobs: if: needs.changes.outputs.python == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main' - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 strategy: fail-fast: false matrix: @@ -173,7 +175,7 @@ jobs: if: needs.changes.outputs.python == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main' - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 env: SQLMESH__DISABLE_ANONYMIZED_ANALYTICS: '1' UV: '1' @@ -202,7 +204,7 @@ jobs: needs.changes.outputs.client == 'true' || needs.changes.outputs.vscode == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main' - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v7 - uses: actions/setup-node@v7 @@ -229,7 +231,7 @@ jobs: if: needs.changes.outputs.client == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main' - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 container: image: mcr.microsoft.com/playwright:v1.54.1-jammy steps: @@ -257,7 +259,7 @@ jobs: if: needs.changes.outputs.python == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main' - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 25 strategy: fail-fast: false @@ -312,7 +314,7 @@ jobs: engine-tests-cloud: needs: engine-tests-docker if: github.ref == 'refs/heads/main' - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 25 strategy: fail-fast: false @@ -424,7 +426,7 @@ jobs: 'true' || github.ref == 'refs/heads/main' env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v7 - uses: actions/setup-node@v7 @@ -443,7 +445,7 @@ jobs: needs.changes.outputs.vscode == 'true' || needs.changes.outputs.lsp == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main' - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v7 - uses: actions/setup-node@v7 @@ -489,7 +491,7 @@ jobs: if: needs.changes.outputs.python == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main' - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 strategy: fail-fast: false matrix: diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index a3e3e820e3..145f301769 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -5,9 +5,10 @@ on: - 'v*.*.*' permissions: contents: write +# Pin Ubuntu 24.04. ubuntu-latest now resolves to 26.04. jobs: ui-build: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v7 - uses: actions/setup-node@v7 @@ -29,7 +30,7 @@ jobs: publish: needs: ui-build - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v7 - name: Download UI build artifact @@ -63,7 +64,7 @@ jobs: run: unset TWINE_USERNAME TWINE_PASSWORD && make publish-tests gh-release: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v7 with: diff --git a/.github/workflows/release_extension.yaml b/.github/workflows/release_extension.yaml index 832f3b466c..9abbfd82a7 100644 --- a/.github/workflows/release_extension.yaml +++ b/.github/workflows/release_extension.yaml @@ -6,9 +6,10 @@ on: description: 'Version to release (e.g., 1.0.0)' required: true type: string +# Pin Ubuntu 24.04. ubuntu-latest now resolves to 26.04. jobs: release: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: Checkout repository uses: actions/checkout@v7 diff --git a/.github/workflows/release_shared_js.yaml b/.github/workflows/release_shared_js.yaml index 98bc29d5df..37aed98fef 100644 --- a/.github/workflows/release_shared_js.yaml +++ b/.github/workflows/release_shared_js.yaml @@ -9,9 +9,10 @@ on: permissions: id-token: write contents: read +# Pin Ubuntu 24.04. ubuntu-latest now resolves to 26.04. jobs: release: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: Checkout repository uses: actions/checkout@v7 diff --git a/vscode/extension/tests/quickfix.spec.ts b/vscode/extension/tests/quickfix.spec.ts index c3f37a2acc..5d1c2e1d24 100644 --- a/vscode/extension/tests/quickfix.spec.ts +++ b/vscode/extension/tests/quickfix.spec.ts @@ -2,6 +2,7 @@ import fs from 'fs-extra' import path from 'path' import { openProblemsView, + saveFile, SUSHI_SOURCE_PATH, waitForLoadedSQLMesh, } from './utils' @@ -78,13 +79,21 @@ test('noselectstar quickfix', async ({ page, sharedCodeServer, tempDir }) => { }) await replaceSelectStar.first().waitFor({ state: 'visible' }) await replaceSelectStar.first().click() + // The code action edits the open document. It stays unsaved until the + // editor writes it, so the on-disk assertion below would keep seeing + // SELECT * on a busy CI runner. + await quickFixMenu.waitFor({ state: 'hidden' }) + await saveFile(page) // Wait for the quick fix to be applied by polling the file content await expect - .poll(async () => { - const content = (await fs.readFile(modelPath)).toString('utf8') - return content.includes('SELECT *') - }) + .poll( + async () => { + const content = (await fs.readFile(modelPath)).toString('utf8') + return content.includes('SELECT *') + }, + { timeout: 15_000 }, + ) .toBeFalsy() // Assert that the model no longer contains SELECT * but SELECT id, customer_id, waiter_id, start_ts, end_ts, event_date