Repository navigation
Conversation
9e8f750 to
5ef934a
Compare
| public: | ||
| using CppType = typename CppTypeTraits<OLAP_FIELD_TYPE_FLOAT>::CppType; | ||
|
|
||
| public: |
There was a problem hiding this comment.
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
| public: |
be/src/olap/key_coder.h:140: previously declared here
public:
^| public: | ||
| static int64_t doubleToLong(double value) { | ||
| union UnionLongDouble { | ||
| int64_t long_; |
There was a problem hiding this comment.
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
| int64_t long_; |
be/src/olap/key_coder.h:179: previously declared here
public:
^| public: | ||
| using CppType = typename CppTypeTraits<OLAP_FIELD_TYPE_DOUBLE>::CppType; | ||
|
|
||
| public: |
There was a problem hiding this comment.
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
| public: |
be/src/olap/key_coder.h:176: previously declared here
public:
^5ef934a to
5c9f50f
Compare
| public: | ||
| using CppType = typename CppTypeTraits<OLAP_FIELD_TYPE_DOUBLE>::CppType; | ||
|
|
||
| public: |
There was a problem hiding this comment.
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
| public: |
be/src/olap/key_coder.h:175: previously declared here
public:
^|
run buildall |
|
TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
closed this pr first, because here are need to rethink the precision matching of float type equal query |
Proposed changes
Issue Number: close #xxx
Problem summary
Support double/float column type in inverted index (for bkd index).
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...