Skip to content

Add --write-sourcemap option to 'bundle' cli command (fixes #3202) - #3204

Merged
martinbigio merged 1 commit into
react:masterfrom
benvinegar:GH-3202
Oct 6, 2015
Merged

martinbigio merged 1 commit into
react:masterfrom
benvinegar:GH-3202

Conversation

@benvinegar

Copy link
Copy Markdown
Contributor

See #3204

@benvinegar

Copy link
Copy Markdown
Contributor Author

Question: should --write-sourcemap (or whatever name you choose) additionally take an output destination? I went with the default filename that is specified as the sourceMappingURL at the bottom of main.jsbundle.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2015
Comment thread local-cli/bundle.js

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be android/app/src/main/assets/index.android.map?

@benvinegar benvinegar changed the title Add --write-sourcemap option to 'bundle' cli command (fixes GH-3202) Add --write-sourcemap option to 'bundle' cli command (fixes #3202) Oct 6, 2015
@martinbigio

Copy link
Copy Markdown
Contributor

@facebook-github-bot shipit

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/636764749796580/int_phab to review.

martinbigio added a commit that referenced this pull request Oct 6, 2015
Add --write-sourcemap option to 'bundle' cli command (fixes #3202)
@martinbigio
martinbigio merged commit 82b3a6b into react:master Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants