Repository navigation
Turn on string ref deprecation warning for everybody (not codemoddable) - #25383
Merged
sebmarkbage merged 3 commits intoNov 17, 2022
Merged
Conversation
eps1lon
force-pushed
the
forwardRef/deprecate-string-refs-only
branch
from
October 2, 2022 14:38
ea0c6a3 to
8b20492
Compare
|
Comparing: d65b88d...6f24ce6 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
changed the title
eps1lon
force-pushed
the
forwardRef/deprecate-string-refs-only
branch
from
October 9, 2022 09:11
8b20492 to
062de60
Compare
sebmarkbage
approved these changes
Nov 16, 2022
added 3 commits
November 16, 2022 21:34
This reverts commit ea096e429a086c57b070e93fe417b89b944a4763.
eps1lon
force-pushed
the
forwardRef/deprecate-string-refs-only
branch
from
November 16, 2022 20:35
062de60 to
6f24ce6
Compare
This was referenced May 17, 2024
This was referenced Nov 11, 2024
This was referenced Nov 11, 2024
This was referenced Nov 11, 2024
This was referenced Nov 12, 2024
This was referenced Nov 12, 2024
This was referenced Nov 12, 2024
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alternate to #25334 without any prod runtime changes i.e. the proposed codemod in https://github.com/reactjs/rfcs/blob/createlement-rfc/text/0000-create-element-changes.md#deprecate-string-refs-and-remove-production-mode-_owner-field would not work.
How did you test this change?
yarn testwith and withoutwarnAboutStringRefs