Merge pull request #4601 from github/josefs/replace-packages-with-node-22-built-ins

Replace `glob` dependency with `glob` from `fs/promises`

Author: josefs

extensions/ql-vscode/package-lock.json

@@ -2155,7 +2155,6 @@
     "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-hooks": "^7.1.1",
     "eslint-plugin-storybook": "^10.6.1",
-    "glob": "^13.0.6",
     "gulp": "^5.0.1",
     "gulp-esbuild": "^0.14.1",
     "gulp-typescript": "^5.0.1",

extensions/ql-vscode/package.json

@@ -6,7 +6,7 @@ import type {
   DatabaseContentsWithDbScheme,
 } from "./database-contents";
 import { DatabaseKind } from "./database-contents";
-import { glob } from "glob";
+import { glob } from "fs/promises";
 import { encodeArchiveBasePath } from "../../common/vscode/archive-filesystem-provider";
 import {
   showAndLogInformationMessage,
@@ -87,17 +87,22 @@ async function findDataset(parentDirectory: string): Promise<Uri> {
   /*
    * Look directly in the root
    */
-  let dbRelativePaths = await glob("db-*/", {
+  const dbRelativePaths: string[] = [];
+  for await (const path of glob("db-*/", {
     cwd: parentDirectory,
-  });
+  })) {
+    dbRelativePaths.push(path);
+  }
 
   if (dbRelativePaths.length === 0) {
     /*
      * Check If they are in the old location
      */
-    dbRelativePaths = await glob("working/db-*/", {
+    for await (const path of glob("working/db-*/", {
       cwd: parentDirectory,
-    });
+    })) {
+      dbRelativePaths.push(path);
+    }
   }
   if (dbRelativePaths.length === 0) {
     throw new InvalidDatabaseError(
@@ -118,7 +123,11 @@ async function findDataset(parentDirectory: string): Promise<Uri> {
 
 /** Gets the relative paths of all `.dbscheme` files in the given directory. */
 async function getDbSchemeFiles(dbDirectory: string): Promise<string[]> {
-  return await glob("*.dbscheme", { cwd: dbDirectory });
+  const dbSchemeFiles: string[] = [];
+  for await (const file of glob("*.dbscheme", { cwd: dbDirectory })) {
+    dbSchemeFiles.push(file);
+  }
+  return dbSchemeFiles;
 }
 
 // exported for testing

extensions/ql-vscode/src/databases/local-databases/database-resolver.ts

@@ -1,6 +1,6 @@
 import { pathExists } from "fs-extra";
 import { basename, join } from "path";
-import { glob } from "glob";
+import { glob } from "fs/promises";
 
 /**
  * The following functions al heuristically determine metadata about databases.
@@ -19,10 +19,10 @@ export async function isLikelyDatabaseRoot(maybeRoot: string) {
     pathExists(join(maybeRoot, "codeql-database.yml")),
 
     // they *must* have a db-{language} folder
-    glob("db-*/", { cwd: maybeRoot }),
+    glob("db-*/", { cwd: maybeRoot }).next(),
   ]);
 
-  return (a || b) && c.length > 0;
+  return (a || b) && !c.done;
 }
 
 /**

extensions/ql-vscode/src/databases/local-databases/db-contents-heuristics.ts

@@ -1,5 +1,5 @@
 import { window } from "vscode";
-import { glob } from "glob";
+import { glob } from "fs/promises";
 import { basename } from "path";
 import { load } from "js-yaml";
 import { readFile } from "fs-extra";
@@ -108,9 +108,12 @@ export async function getQlPackForDbscheme(
 export async function getPrimaryDbscheme(
   datasetFolder: string,
 ): Promise<string> {
-  const dbschemes = await glob("*.dbscheme", {
+  const dbschemes: string[] = [];
+  for await (const file of glob("*.dbscheme", {
     cwd: datasetFolder,
-  });
+  })) {
+    dbschemes.push(file);
+  }
 
   if (dbschemes.length < 1) {
     throw new Error(