Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

fix: Add documentation to Exceptions - #1745

Merged
yirutang merged 5 commits into
googleapis:mainfrom
yirutang:inflightException
Aug 12, 2022
Merged

fix: Add documentation to Exceptions#1745
yirutang merged 5 commits into
googleapis:mainfrom
yirutang:inflightException

Conversation

@yirutang

@yirutang yirutang commented Aug 12, 2022

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@yirutang
yirutang requested review from a team and loferris August 12, 2022 00:14
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Aug 12, 2022
@yirutang
yirutang requested a review from shollyman August 12, 2022 00:14
shollyman
shollyman reviewed Aug 12, 2022
View reviewed changes

@shollyman shollyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some alternate language for each of these.

Comment thread google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Resolved
Comment thread google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Resolved
Comment thread google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Resolved
Comment thread google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Resolved
Comment thread google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Resolved
@yirutang
yirutang requested a review from a team August 12, 2022 17:47
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022
@yirutang yirutang added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 12, 2022
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 12, 2022
@yirutang
yirutang merged commit 3bc7aca into googleapis:main Aug 12, 2022
@release-please release-please Bot mentioned this pull request Aug 12, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@loferris loferris Awaiting requested review from loferris
1 more reviewer
@shollyman shollyman shollyman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yirutang @shollyman @yoshi-kokoro