Skip to content

secrets: add job id and namespace to plugin env - #27207

Merged
mismithhisler merged 2 commits into
mainfrom
f-secret-plugin-add-ns-and-jobid
Dec 8, 2025
Merged

mismithhisler merged 2 commits into
mainfrom
f-secret-plugin-add-ns-and-jobid

Conversation

@mismithhisler

@mismithhisler mismithhisler commented Dec 8, 2025 •

Copy link
Copy Markdown
Member

Description

These changes add the nomad Job ID and namespace to a secret plugin's environment, overwriting anything set by the user.

Testing & Reproduction steps

Links

Fixes GH #27015

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

@allisonlarson allisonlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mismithhisler
mismithhisler merged commit cfb2bbc into main Dec 8, 2025
54 of 55 checks passed
@mismithhisler
mismithhisler deleted the f-secret-plugin-add-ns-and-jobid branch December 8, 2025 22:04
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 8, 2026

This branch was successfully deployed

1 active deployment
Preview – nomad-ui — c11621fb Deployed Dec 8, 2025 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/1.11.x backport to 1.11.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide job id and namespace for secrets plugins

2 participants