Skip to content

Forward OIDC iss param from UI during login - #27248

Merged
allisonlarson merged 3 commits into
mainfrom
b-fix-oidc-ui
Dec 12, 2025
Merged

allisonlarson merged 3 commits into
mainfrom
b-fix-oidc-ui

Conversation

@allisonlarson

@allisonlarson allisonlarson commented Dec 11, 2025 •

Copy link
Copy Markdown
Contributor

Description

Fixes an issue where the iss param isn't getting forwarded from the UI during the login, preventing successful login when the iss parameter is required.

Testing & Reproduction steps

Attempt to login with an OIDC provider that requires the iss parameter in the UI

Links

Fixes #27245

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

chrisroberts
chrisroberts previously approved these changes Dec 12, 2025
pkazmierczak
pkazmierczak previously approved these changes Dec 12, 2025

@pkazmierczak pkazmierczak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't have a bindata_assetfs.go update in the PR. That gets added only in the release, to keep repo growth from exploding over time.

@allisonlarson

Copy link
Copy Markdown
Contributor Author

@tgross Whoops, thank you! bindata_assetfs.go changes have been removed. I saw that its in the gitignore, so I'm not sure why it got picked up.

@allisonlarson allisonlarson added backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.10.x+ent backport to 1.10.x+ent release line backport/1.11.x backport to 1.11.x release line labels Dec 12, 2025
@allisonlarson
allisonlarson merged commit 33eb273 into main Dec 12, 2025
44 of 46 checks passed
@allisonlarson
allisonlarson deleted the b-fix-oidc-ui branch December 12, 2025 20:09
@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 12, 2026

This branch was successfully deployed

1 active deployment
Preview – nomad-ui — 14b8fb08 Deployed Dec 12, 2025 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.10.x+ent backport to 1.10.x+ent release line backport/1.11.x backport to 1.11.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OIDC SSO fails in UI because iss query parameter is not consumed

4 participants