Repository navigation
Forward OIDC iss param from UI during login - #27248
Merged
Merged
Conversation
chrisroberts
previously approved these changes
Dec 12, 2025
tgross
requested changes
Dec 12, 2025
tgross
left a comment
Member
There was a problem hiding this comment.
We shouldn't have a bindata_assetfs.go update in the PR. That gets added only in the release, to keep repo growth from exploding over time.
allisonlarson
force-pushed
the
b-fix-oidc-ui
branch
from
December 12, 2025 17:53
5e1f56c to
14b8fb0
Compare
Contributor
Author
|
@tgross Whoops, thank you! |
chrisroberts
approved these changes
Dec 12, 2025
tgross
approved these changes
Dec 12, 2025
2 of 7 tasks
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the
issparam isn't getting forwarded from the UI during the login, preventing successful login when theissparameter is required.Testing & Reproduction steps
Attempt to login with an OIDC provider that requires the
issparameter in the UILinks
Fixes #27245
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.