Repository navigation
acl: allow host-volume-delete capability to pass validation - #27434
Merged
Merged
Conversation
When we added ACLs for dynamic host volumes, we missed marking the `host-volume-delete` capability as valid. Fix this and add a test that prevents us from making similar mistakes in the future by reading the source for constants we care about and checking them. Fixes: #27433
tgross
force-pushed
the
b-acl-validation
branch
from
January 29, 2026 16:04
d74397e to
eeffcd6
Compare
tgross
marked this pull request as ready for review
January 29, 2026 17:06
Member
Author
|
Security scan issue is a credentials config issue. Being discussed here: https://ibm-hashicorp.slack.com/archives/C09KSMGTVPV/p1769703193263569 (internal) |
gulducat
previously approved these changes
Jan 29, 2026
gulducat
left a comment
gulducat
left a comment
Member
There was a problem hiding this comment.
As usual, I'm obsessed about test minutia, but LGTM!
| // valid | ||
| func TestPolicy_isCapabilityValid(t *testing.T) { | ||
| filename := "policy.go" | ||
| src, err := os.ReadFile(filename) |
tgross
added
backport/ent/1.10.x+ent
Merged
2 of 7 tasks
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we added ACLs for dynamic host volumes, we missed marking the
host-volume-deletecapability as valid. Fix this and add a test that prevents us from making similar mistakes in the future by reading the source for constants we care about and checking them.Fixes: #27433
Description
Testing & Reproduction steps
Links
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.