Skip to content

ui: Fix region identifier showing empty in single region clusters. - #28310

Merged
jrasell merged 2 commits into
mainfrom
b-ui-region-selector-single-region
Jul 29, 2026
Merged

jrasell merged 2 commits into
mainfrom
b-ui-region-selector-single-region

Conversation

@jrasell

@jrasell jrasell commented Jul 28, 2026 •

Copy link
Copy Markdown
Member

The region picker should display the configured region when the cluster is not federated. Previously the picker would return null if a region was not stored in localstorage which in single region clusters resulted in an empty region identifier.

The change ensures this is populated with the region identifier if no region is found in localstorage and there are no federated clusters.

Testing & Reproduction steps

Run nomad agent -dev -region=nmd-eng with and without this change and check the header on the UI landing page when authenticated.

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.
  • LLM Usage If an LLM was used to generate any code, please ensure and confirm you have read
    and followed the AI usage guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

The region picker should display the configured region when the
cluster is not federated. Previously the picker would return null
if a region was not stored in localstorage which in single region
clusters resulted in an empty region identifier.

The change ensures this is populated with the region identifier
if no region is found in localstorage and there are no federated
clusters.
@jrasell jrasell self-assigned this Jul 28, 2026
@jrasell jrasell added backport/ent/1.10.x+ent backport to 1.10.x+ent release line backport/ent/1.11.x+ent backport to 1.11.x+ent release line backport/2.0.x backport to 2.0.x release line labels Jul 28, 2026
@jrasell
jrasell requested review from mismithhisler and tehut July 28, 2026 11:48
@jrasell
jrasell marked this pull request as ready for review July 28, 2026 11:48
@jrasell
jrasell requested review from a team as code owners July 28, 2026 11:48

@navyadas-dev navyadas-dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jrasell
jrasell merged commit 7b6885e into main Jul 29, 2026
30 checks passed
@jrasell
jrasell deleted the b-ui-region-selector-single-region branch July 29, 2026 06:31
schmichael pushed a commit to vercel/nomad that referenced this pull request Sep 25, 2026
…ashicorp#28310)

The region picker should display the configured region when the
cluster is not federated. Previously the picker would return null
if a region was not stored in localstorage which in single region
clusters resulted in an empty region identifier.

The change ensures this is populated with the region identifier
if no region is found in localstorage and there are no federated
clusters.

This branch was successfully deployed

1 active deployment
Preview — fbf5773a Deployed Jul 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/ent/1.10.x+ent backport to 1.10.x+ent release line backport/ent/1.11.x+ent backport to 1.11.x+ent release line backport/2.0.x backport to 2.0.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants