Repository navigation
api: prefer table index on initial GetClientAllocs - #28394
Merged
Merged
Conversation
chrisroberts
added
backport/ent/1.10.x+ent
When the query is initially run, the previous count of allocations is unknown. If the request is made with a minimum query index value and an allocation has just been deleted, this will not be correctly detected and the query will block. To prevent this, always prefer the allocs table index on the initial run.
chrisroberts
force-pushed
the
f-get-client-allocs-dels
branch
from
August 6, 2026 22:36
34f4552 to
bf062df
Compare
tgross
approved these changes
Aug 7, 2026
tgross
left a comment
tgross
left a comment
Member
There was a problem hiding this comment.
LGTM!
But is there any strong reason not to always use the table index here instead of having the branch?
Member
Author
8 tasks
schmichael
pushed a commit
to vercel/nomad
that referenced
this pull request
Sep 25, 2026
When the query is initially run, the previous count of allocations is unknown. If the request is made with a minimum query index value and an allocation has just been deleted, this will not be correctly detected and the query will block. To prevent this, always prefer the allocs table index on the initial run.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the
Node.GetClientAllocsquery is initially run, the previous count of allocations is unknown. If the request is made with a minimum query index value and an allocation has just been deleted, this will not be correctly detected and the query will block. To prevent this, always prefer the allocs table index on the initial run.This surfaced in #28242 where the existing behavior resulted in allocations that were still running after being deleted.
Testing & Reproduction steps
Test included.
Links
Fixes #28242
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.and followed the AI usage guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.