Repository navigation
chore: bump js-yaml to fix high Dependabot alert #79 (GHSA-5p4m-2wfm-xmqj) - #168
Merged
Merged
Conversation
Bumps transitive dev dependency js-yaml to patched releases: - 4.3.0 -> 4.3.1 (via eslint/mocha) - 3.15.0 -> 3.15.1 (via nyc/@istanbuljs/load-nyc-config) Fixes O(n^2) CPU consumption in !!omap resolution (CWE-407, CVSS 7.5). Both patched versions satisfy the existing semver ranges; lockfile-only change. Verified: n=80000 !!omap load drops from ~2600ms to ~80ms, and duplicate-key rejection semantics are preserved.
gsinghsfdc
approved these changes
Aug 18, 2026
hsophie-sf
approved these changes
Aug 18, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Dependabot alert #79 — a high-severity (CVSS 7.5, CWE-407) denial-of-service in
js-yaml's!!omapresolution, which is O(n²) in the number of entries and can stall the Node event loop on a small untrusted YAML input.js-yamlis a transitive, dev-only dependency here (via eslint/mocha and nyc). Two vulnerable versions were resolved inyarn.lock:js-yaml(4.x)js-yaml(3.x)Both patched releases satisfy the existing semver ranges (
^4.1.0,^3.13.1), so this is a lockfile-only change — nopackage.jsonedits.What Changed
yarn.lock:js-yaml4.3.0 → 4.3.1 and 3.15.0 → 3.15.1 (version, resolved URL, integrity).Testing
Ran the advisory's proof-of-concept against the installed patched versions:
n=80000!!omapload dropped from ~2600ms (reported for 4.3.0) to 80ms; timings now grow linearly (26 / 26 / 39 / 80 ms as n doubles) rather than quadratically.n=80000load in 90ms.YAMLExceptionstill thrown on duplicate omap keys).yarn installaccepts the lockfile with no collateral changes.Checklist