From f5f81bebf848c5fa2cbfc6f8677e2ab76115e4f7 Mon Sep 17 00:00:00 2001 From: Josh Gavant Date: Fri, 24 Mar 2017 10:44:32 -0700 Subject: [PATCH] doc: add CTC meeting minutes 2017-03-22 --- meetings/2017-03-22.md | 184 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 184 insertions(+) create mode 100644 meetings/2017-03-22.md diff --git a/meetings/2017-03-22.md b/meetings/2017-03-22.md new file mode 100644 index 0000000..355a407 --- /dev/null +++ b/meetings/2017-03-22.md @@ -0,0 +1,184 @@ +# Node Foundation CTC Meeting 2017-03-22 + +## Links + +* **Audio recording**: +* **GitHub Issue**: [CTC#82](https://github.com/nodejs/CTC/issues/82) +* **Minutes Google Doc**: +* _Previous Minutes Google Doc_: + +## Present + +* Anna Henningsen @addaleax (CTC) +* Ben Noordhuis @bnoordhuis (CTC) +* Сковорода Никита Андреевич @ChALkeR (CTC) +* James M Snell @jasnell (CTC) +* Josh Gavant @joshgav (observer/TSC) +* Brian White @mscdex (CTC) +* Myles Borins @MylesBorins (CTC) +* Rod Vagg @rvagg (CTC) +* Sakthipriyan Vairamani @thefourtheye (CTC) +* Trevor Norris @trevnorris (CTC) +* Rich Trott @Trott (CTC) +* Arunesh Chandra (observer/Microsoft) +* Hitesh Kanwathirtha (observer/Microsoft) + +## Standup + +* Anna Henningsen @addaleax (CTC) + * not much besides Issue/PR review +* Ben Noordhuis @bnoordhuis (CTC) + * the usual +* Сковорода Никита Андреевич @ChALkeR (CTC) + * nothing significant +* James M Snell @jasnell (CTC) + * Mostly nearForm onboarding + * PR landing + * Buffer PR splitting +* Josh Gavant @joshgav (observer/TSC) + * presentations prep + * diag meeting Thursday + * typical issue triage +* Brian White @mscdex (CTC) + * Continued work on various optimizations in core + * Reviewed PRs, commented on issues +* Myles Borins @MylesBorins (CTC) + * Released v4.8.1 && v6.10.1 + * 100th release of citgm + * attending TC39 this week +* Rod Vagg @rvagg (CTC) + * Minor infra maintenance +* Sakthipriyan Vairamani @thefourtheye (CTC) + * Not much +* Trevor Norris @trevnorris (CTC) + * Submitted AsyncHooks PR +* Rich Trott @Trott (CTC) + * Fix some flaky tests + * Increase test coverage + * Helped some first-time contributors via NodeTodo + +## Agenda + +* buffer: discuss future direction of Buffer constructor API [node#9531](https://github.com/nodejs/node/issues/9531) +* module: add support for abi stable module API [node#11975](https://github.com/nodejs/node/issues/11975) + +## Previous Meeting Review + +* Symbol key props visible in inspection by default [node#9726](https://github.com/nodejs/node/pull/9726) + * Landed! +* Updating the Copyright [TSC#174](https://github.com/nodejs/TSC/issues/174) + * Moved to ctc-review, no new updates. +* TC39 + Node.js Summit / Dinner [CTC#67](https://github.com/nodejs/CTC/issues/67) + * Awareness. + +--- + +## Minutes + +### buffer: discuss future direction of Buffer constructor API [node#9531](https://github.com/nodejs/node/issues/9531) + +@Trott: + +1. When (if?) should we schedule a runtime deprecation for `new Buffer()`? +2. Should that regular deprecation be preceded with a "Pending Deprecation" hidden behind a `--pending-deprecation` flag? +3. Should we implement a buffer filling mechansim, and if so zero or a random pattern? + * Why random-fill? So that people wouldn’t realize buffers were being zero-filled and rely on that behavior. + * @trevnorris: random filling doesn’t fit pattern of UInt8Array. + +* PR for --pending-deprecation flag: https://github.com/nodejs/node/pull/11968 +* PR for fill mechanism: https://github.com/nodejs/node/pull/11808 + +@rvagg: Can we deprecate just one signature of the constructor, i.e. the one that takes an int? + +@trevnorris: Once we bump a minor version, we don’t support previous minor versions, so why are we concerned with those using older minors? + +@bnoordhuis: Those who depend on releases from Linux distros don’t get minor updates for a while. + +@mylesborins: That’s true of any security patches, if you use unpatched earlier versions you don’t have the patch… + +@ChALkeR: Later modules may come to rely on zero-filled buffers, and those modules may be used with out-of-date earlier versions. + +@rvagg: This is a massive ship to be turning, we should opt for greater patience, encourage people through docs and other channels. + +@jasnell: This is one of the reasons for --pending-deprecation. Also other tools and linters are warning more. + +@ChALkeR: I would support optin deprecation for now and a plan for later actual deprecation. + +@jasnell: If we will land with filling it should be decided before 8.0 RCs (Apr-4). + +@rvagg: May not be semver-major, especially if random-fill. + +**Next steps** + +* Continue discussion within GitHub issues. + +--- + +### module: add support for abi stable module API [node#11975](https://github.com/nodejs/node/issues/11975) + +Export an API and ABI stable C and C++ interface for native module developers. + +@arunesh: Experimental, guarded by runtime flag. Goal is more feedback from community and module authors. V8 APIs used in 5+ of top 30 native modules are covered by a N-API equivalent. + +@jasnell: Goal is to get into 8.0.0 as experimental. + +@trevnorris: Converting a lot to void\*, how does it ensure the safety of what’s being passed? + +@digitialinfinity: Type checking is done within implementation. + +@jasnell: Does anyone object to this going into 8.0.0? + +@bnoordhuis: Pretty big PR, will be hard to review by Apr-4. + +@jasnell: Can we set a target for a week before final 8.0.0 release? It’s not semver-major. + +@rvagg: Can NAN be backed by this API? @digitalinfinity: C++ header-only wrapper is similar to NAN. Some discussion of considering that NAN 3.0. Haven’t considered backing NAN, worth considering. Hope to provide tools to aid migration after some adoption and feedback. + +**Next steps** + +* Review PR and provide feedback. + +--- + +### async\_hooks initial implementation [#11883](https://github.com/nodejs/node/pull/11883) + +@trevnorris: rewrote more cleanly, would like more feedback. Tried to be as least invasive as possible. Comes with a whole bunch of tests. + +There are even async\_hooks in the async\_hooks tests to check for stuck previous tasks. + +Touches many places in Node, hence want a lot of review. + +@mylesborins: thoughts about using PromiseHooks from V8? @trevnorris: won’t be in V8 in 8.0.0, but as soon as it is I’ll integrate. + +@joshgav: PromiseHooks is in V8 5.7 which will land in master shortly, see [node#11752](https://github.com/nodejs/node/pull/11752). + +@rvagg: not a semver-major, and anyway still experimental, but still would be nice to have in 8. + +@trevnorris: need to add docs, move around some tests. + +**Next steps** + +* Review PR and provide feedback. + +--- + +## Q&A, Other + +None. + +--- + +## Upcoming Meetings + +* **Node.js Foundation Calendar**: https://calendar.google.com/calendar/embed?src=kap.co_i17i575te0aes6kaanfjr2e4hs%40group.calendar.google.com + +Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. + +* **Collaborators Summit**: May 4-5, + [summit#39](https://github.com/nodejs/summit/issues/39) +* **TC39 Meetup**: May 22, + [CTC#67](https://github.com/nodejs/CTC/issues/67) + +* **CTC**: March 29, 1600 UTC +* **TSC**: March 23, 2000 UTC +* **Diag**: March 23, 2100 UTC