Repository navigation
fix: isolate cluster metadata per probe target - #1259
Open
wangyusheng1985 wants to merge 1 commit into
Open
wangyusheng1985 wants to merge 1 commit into
wangyusheng1985 wants to merge 1 commit into
Conversation
Signed-off-by: yusheng.wang <yusheng.wang@chaitin.com>
Contributor
|
This is already fixed on the master branch. It was resolved in #1147. The one thing that this PR does seem to add is some extra testing which could be useful. Do you want to close this or cut the changes down to just the tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the
/probeendpoint into a standalonenewProbeHandlerand ensure per-probe instances ofcluster.InfoProvider,ElasticsearchCollector, and Prometheus registry are isolated per request, preventing target A cluster metadata (clusterandcluster_uuid) from bleeding into target B. Add end-to-end multi-target probe tests.Closes #1248