Skip to content

fix: document Gradle fork build and warn on missing native library - #18

Merged
not-matthias merged 2 commits into
mainfrom
cod-3980-fix-jvm-setup-documentation-and-silent-missing-native
Oct 23, 2026
Merged

not-matthias merged 2 commits into
mainfrom
cod-3980-fix-jvm-setup-documentation-and-silent-missing-native

Conversation

@not-matthias

Copy link
Copy Markdown
Member

Fixes COD-3980.

  • README/AGENTS.md: build the fork with ./gradlew -p jmh-fork publishToMavenLocal (plus git submodule update --init --recursive). The Maven build does not compile or bundle libinstrument_hooks_jni.so / libperf_map_agent.so, so the fork silently fell back to plain JMH.
  • InstrumentHooks: when running under the CodSpeed runner (CODSPEED_ENV set) and the native library cannot load, print a warning to stderr instead of falling back silently. Behavior outside the runner is unchanged.

…ng under CodSpeed

The README said to build the fork with Maven, which does not bundle the
native libraries. The fork then silently ran as plain JMH and produced no
results. Document the Gradle build with recursive submodule init, and print
a warning when CODSPEED_ENV is set but the native library cannot load.
@not-matthias
not-matthias marked this pull request as ready for review October 22, 2026 14:55
@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Updates the local build instructions to use Gradle so Linux builds include the native libraries.

  • JMH fork setup now uses Gradle to include CodSpeed's native libraries.
  • CodSpeed runs now warn when the native hooks library is missing.

Reviews (1) · Last reviewed commit: "fix: document Gradle fork build and warn..." · Reviewed by Greptile

@codspeed

codspeed Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 14 untouched benchmarks
⏩ 121 skipped benchmarks1


Comparing cod-3980-fix-jvm-setup-documentation-and-silent-missing-native (29d18a7) with main (af05f6f)

Open in CodSpeed

Footnotes

  1. 121 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@not-matthias
not-matthias force-pushed the cod-3980-fix-jvm-setup-documentation-and-silent-missing-native branch from 2518865 to 29d18a7 Compare October 22, 2026 15:07
@not-matthias
not-matthias requested a review from lvaroqui October 22, 2026 15:07
@not-matthias
not-matthias merged commit 29d18a7 into main Oct 23, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants