Repository navigation
fix: document Gradle fork build and warn on missing native library - #18
Merged
not-matthias merged 2 commits intoOct 23, 2026
Merged
not-matthias merged 2 commits into
not-matthias merged 2 commits into
Conversation
…ng under CodSpeed The README said to build the fork with Maven, which does not bundle the native libraries. The fork then silently ran as plain JMH and produced no results. Document the Gradle build with recursive submodule init, and print a warning when CODSPEED_ENV is set but the native library cannot load.
not-matthias
marked this pull request as ready for review
October 22, 2026 14:55
[Medium impact] The PR appears safe to merge. SummaryUpdates the local build instructions to use Gradle so Linux builds include the native libraries.
Reviews (1) · Last reviewed commit: "fix: document Gradle fork build and warn..." · Reviewed by Greptile |
Merging this PR will not alter performance
Comparing Footnotes
|
not-matthias
force-pushed
the
cod-3980-fix-jvm-setup-documentation-and-silent-missing-native
branch
from
October 22, 2026 15:07
2518865 to
29d18a7
Compare
lvaroqui
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes COD-3980.
./gradlew -p jmh-fork publishToMavenLocal(plusgit submodule update --init --recursive). The Maven build does not compile or bundlelibinstrument_hooks_jni.so/libperf_map_agent.so, so the fork silently fell back to plain JMH.InstrumentHooks: when running under the CodSpeed runner (CODSPEED_ENVset) and the native library cannot load, print a warning to stderr instead of falling back silently. Behavior outside the runner is unchanged.