Repository navigation
chore(plans): gitsheets adoption + legacy handle redirects - #196
Merged
Merged
Conversation
Upstream gitsheets#184 shipped in 2.3.1 (refresh, readBlobStream, withLock), unblocking the second half of #150. Plan the bump to 2.7 and the retirement of swapPublic, the raw cat-file attachment path, and data-repo-lock, plus the stripNullish/asValidator shims 2.3 made redundant. Also captures a live race: no write path takes dataRepoLock, so the hot-reload webhook can race a transact despite storage.md saying otherwise; withLock shares the transact mutex and closes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Retroactive closeout: #151 merged 2026-07-04 but the plan was left in-progress. Defers the workaround retirement to gitsheets-freshness. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The data repo's slug-history.toml templates on ${{ slug }}, but the
schema field is oldSlug, so every slug rename and account-claim merge
throws path_render_failed and 500s in production. Tests missed it
because they carry their own corrected config copies; the plan fixes the
config and single-sources configs for tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds the remaining 2.7-addressable cleanups: reconcile pushes via the push daemon, revocations reloaded on hot reload, webhook branch override rejected, sheet-indices deleted, attachments via sheet.getAttachment with an ETag. Fetch moves outside the lock; depends on slug-history-config so validation runs against real configs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
incremental-reload (diffFrom), gitsheets-scripts (prune-spam, importer, scrub-data off raw git), gitsheets-sync (reconcile -> upstream sync), slug-rename-attachments (renames drop avatars), and person-evaluations-contract. Upstream asks are recorded as awaits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
themightychris
force-pushed
the
chore/gitsheets-freshness
branch
from
October 13, 2026 23:56
29f27d9 to
0919470
Compare
The import lowercased and re-punctuated legacy handles (66 of 269 projects), but the spec claimed they were preserved verbatim, and lookups are exact-match, so legacy links with capitals or dots 404. Specify a web-layer normalization fallback that 301s permanently, outside the expiring slug-history mechanism. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plans-only PR. It closes out
gitsheets-2x-bumpafter the fact (#151 merged on 2026-07-04 but was leftin-progress), and adds a set of plans to adopt gitsheets 2.7 fully and remove our workarounds.slug-history-configslug-history.tomltemplates on${{ slug }}but the schema field isoldSlug, so every slug rename and account-claim merge returns 500 in prod. Tests missed it because they carry their own config copies. This plan fixes the config and makes tests use one canonical source.gitsheets-freshnessswapPublicwithrefresh(),data-repo-lockwithwithLock()(this fixes a live webhook-vs-write race), and the rawcat-fileattachment reads withgetAttachmentplus anETag. Route reconcile's pushes through the push daemon, reload revocations on hot reload, and delete thestripNullish/asValidatorshims andsheet-indices.incremental-reloadsheet.diffFromchanges instead of rebuilding everythinggitsheets-scriptsgitsheets-syncreconcile.tsmoves to an upstreamrepo.sync()slug-rename-attachmentsperson-evaluations-contract🤖 Generated with Claude Code