Skip to content

chore(plans): gitsheets adoption + legacy handle redirects - #196

Merged
themightychris merged 7 commits into
developfrom
chore/gitsheets-freshness
Oct 14, 2026
Merged

themightychris merged 7 commits into
developfrom
chore/gitsheets-freshness

Conversation

@themightychris

@themightychris themightychris commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Plans-only PR. It closes out gitsheets-2x-bump after the fact (#151 merged on 2026-07-04 but was left in-progress), and adds a set of plans to adopt gitsheets 2.7 fully and remove our workarounds.

Plan What Blocked on
slug-history-config Live bug. The data repo's slug-history.toml templates on ${{ slug }} but the schema field is oldSlug, so every slug rename and account-claim merge returns 500 in prod. Tests missed it because they carry their own config copies. This plan fixes the config and makes tests use one canonical source. —
gitsheets-freshness Bump to 2.7. Replace swapPublic with refresh(), data-repo-lock with withLock() (this fixes a live webhook-vs-write race), and the raw cat-file attachment reads with getAttachment plus an ETag. Route reconcile's pushes through the push daemon, reload revocations on hot reload, and delete the stripNullish/asValidator shims and sheet-indices. slug-history-config
incremental-reload Hot reload applies sheet.diffFrom changes instead of rebuilding everything freshness
gitsheets-scripts prune-spam, the importer and scrub-data stop using raw git and hand-written TOML. This fixes a utf8 slicing bug, an O(n²) lookup, dropped attachments and blog posts written in the wrong format. freshness, plus upstream (partly)
gitsheets-sync reconcile.ts moves to an upstream repo.sync() upstream
slug-rename-attachments A slug rename deletes and re-creates the record, which drops the avatar. Interim fix now, then an upstream move-with-attachments. slug-history-config, upstream
person-evaluations-contract gitsheets schema contract shared by cfp, the data repo and the spam pipeline freshness

🤖 Generated with Claude Code

@themightychris themightychris changed the title chore(plans): close out gitsheets-2x-bump, plan gitsheets-freshness chore(plans): close out gitsheets-2x-bump, plan full gitsheets adoption Oct 13, 2026
themightychris and others added 5 commits October 13, 2026 19:56
Upstream gitsheets#184 shipped in 2.3.1 (refresh, readBlobStream,
withLock), unblocking the second half of #150. Plan the bump to 2.7 and
the retirement of swapPublic, the raw cat-file attachment path, and
data-repo-lock, plus the stripNullish/asValidator shims 2.3 made
redundant.

Also captures a live race: no write path takes dataRepoLock, so the
hot-reload webhook can race a transact despite storage.md saying
otherwise; withLock shares the transact mutex and closes it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Retroactive closeout: #151 merged 2026-07-04 but the plan was left
in-progress. Defers the workaround retirement to gitsheets-freshness.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The data repo's slug-history.toml templates on ${{ slug }}, but the
schema field is oldSlug, so every slug rename and account-claim merge
throws path_render_failed and 500s in production. Tests missed it
because they carry their own corrected config copies; the plan fixes the
config and single-sources configs for tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds the remaining 2.7-addressable cleanups: reconcile pushes via the
push daemon, revocations reloaded on hot reload, webhook branch override
rejected, sheet-indices deleted, attachments via sheet.getAttachment with
an ETag. Fetch moves outside the lock; depends on slug-history-config so
validation runs against real configs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
incremental-reload (diffFrom), gitsheets-scripts (prune-spam, importer,
scrub-data off raw git), gitsheets-sync (reconcile -> upstream sync),
slug-rename-attachments (renames drop avatars), and
person-evaluations-contract. Upstream asks are recorded as awaits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@themightychris
themightychris force-pushed the chore/gitsheets-freshness branch from 29f27d9 to 0919470 Compare October 13, 2026 23:56
themightychris and others added 2 commits October 13, 2026 19:57
The import lowercased and re-punctuated legacy handles (66 of 269
projects), but the spec claimed they were preserved verbatim, and lookups
are exact-match, so legacy links with capitals or dots 404. Specify a
web-layer normalization fallback that 301s permanently, outside the
expiring slug-history mechanism.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@themightychris themightychris changed the title chore(plans): close out gitsheets-2x-bump, plan full gitsheets adoption chore(plans): gitsheets adoption + legacy handle redirects Oct 13, 2026
@themightychris
themightychris merged commit 662a32a into develop Oct 14, 2026
1 check passed
@themightychris
themightychris deleted the chore/gitsheets-freshness branch October 14, 2026 02:39
@themightychris themightychris mentioned this pull request Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant