Repository navigation
End keyboard column resizes on keyup and blur - #4249
Merged
Merged
Conversation
Only the resize handle's lost pointer capture ended a column resize. After a resize with Ctrl+Arrow keys, the grid didn't call `onColumnWidthsChange`, and ignored the `columnWidths` prop until the user finished resizing a column with the pointer. Split from #4005. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4249 +/- ##
=======================================
Coverage 99.22% 99.23%
=======================================
Files 44 44
Lines 2207 2215 +8
Branches 971 974 +3
=======================================
+ Hits 2190 2198 +8
Misses 17 17
🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nstepien
added a commit
that referenced
this pull request
Oct 27, 2026
#4249 added the same keyboard resize code and test as this branch, in other places: keep one copy of each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the resize handle's
onLostPointerCapturecalledonColumnResizeEnd, so resizing a column with Ctrl+ArrowLeft or Ctrl+ArrowRight never ended the resize.isColumnResizingstayedtrueuntil the user finished resizing a column with the pointer, and until then:onColumnWidthsChange.columnWidthsandonColumnWidthsChange, the grid used its internal widths and ignored thecolumnWidthsprop. For example,setColumnWidths(new Map())didn't reset the widths.Changes
resizable.test.tsxcover the key release, the loss of focus, and thecolumnWidthsprop after a keyboard resize. They fail onmainin Chromium.Split from #4005.
vp run cipasses.🤖 Generated with Claude Code