Skip to content

Initial port of library code to new library - #1

Merged
madpah merged 44 commits into
mainfrom
features/initial-port-of-v1.1-generation-from-jake
Sep 6, 2021
Merged

madpah merged 44 commits into
mainfrom
features/initial-port-of-v1.1-generation-from-jake

Conversation

@madpah

@madpah madpah commented Aug 31, 2021

Copy link
Copy Markdown
Collaborator

No description provided.

madpah added 25 commits August 27, 2021 11:15
…le place to define which schema version support various attributes and elements.
@madpah

madpah commented Sep 1, 2021

Copy link
Copy Markdown
Collaborator Author

@DarthHater / @bhamail / @alindley

Looking for any feedback at this point.

Library structure is in place with basic support across JSON and XML for schema versions 1.0 through 1.3. Would very much like to get this branch merged to master so we can consider:

  1. Early release to PyPi - this allows pip install ... so we can start raising PR's for jake and the main cylconedx python application to use this library
  2. Potential relocation of this library to CycloneDX GitHub org?
  3. Getting into a release process for this library

Any and all comments welcome/apprectiated.

@DarthHater

Copy link
Copy Markdown
Member

We should do 2 before we do 1 and 3, mainly because this would definitely be best served as released under the cyclonedx umbrella

@DarthHater

Copy link
Copy Markdown
Member

@coderpatros @stevespringett tagging you two for visibility on this! Pretty rad.

@DarthHater

Copy link
Copy Markdown
Member

Big feedback:

  • Let's use poetry if possible for packaging, managing deps. I think it's great in comparison to pip's warts
  • Let's switch from CircleCI to GitHub Actions, that's how the rest of the CycloneDX stuff is setup, if we want to transfer it (we do!) it'll be good to be consistent
  • LICENSE HEADERS :)
  • License (Apache 2)

I'd say merge this to main when you feel like it, then @bhamail and I can likely start picking away at it too!

@madpah

madpah commented Sep 2, 2021

Copy link
Copy Markdown
Collaborator Author

@DarthHater - added Poetry support and GitHub actions.

If acceptable, I'll cleanup CircleCI and PIP related stuff.

FYI: @bhamail

@DarthHater

Copy link
Copy Markdown
Member

Rad!!!!

@madpah

madpah commented Sep 3, 2021

Copy link
Copy Markdown
Collaborator Author

@DarthHater - ensured support now for Python 3.7+ (not checked 3.6 just yet as brew seems to have yanked support for it!).

@madpah

madpah commented Sep 3, 2021

Copy link
Copy Markdown
Collaborator Author

Support for Python 3.6 confirmed now also @DarthHater

@madpah
madpah merged commit 2f2634b into main Sep 6, 2021
@madpah
madpah deleted the features/initial-port-of-v1.1-generation-from-jake branch September 6, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants