Skip to content

Add search to Process overview - #6368

Open
aprilherron wants to merge 1 commit into
DSpace:mainfrom
atmire:w2p-144570_index-processes-discovery
Open

aprilherron wants to merge 1 commit into
DSpace:mainfrom
atmire:w2p-144570_index-processes-discovery

Conversation

@aprilherron

@aprilherron aprilherron commented Oct 15, 2026 •

Copy link
Copy Markdown

References

Description

The intent of this work is to provide a search interface for DSpace Administrative Processes.

Instructions for Reviewers

Sign in as an Administrator and visit the "Processes" page.
A search bar should now appear at the top of the page and you should be able to search existing processes by the following criteria:

  • Process ID
  • Process Name
  • User Name
  • User email
  • Start Time
  • Finish Time
  • Status
  • Arguments
  • Output Files
  • Total process size

Before Search:
Screenshot 2026-10-15 at 5 29 12 PM

After Search:
Screenshot 2026-10-15 at 5 30 19 PM

The Angular side changes create the user interface, make calls to the appropriate endpoints, and filter results accordingly.

AI Disclosure (REQUIRED)

Were AI tools used in the creation of this PR?

  • No (This PR does NOT include AI-generated or AI-assisted content that requires disclosure.)
  • Yes (This PR includes AI-generated or AI-assisted content that requires disclosure.)

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added new feature component: administrative tools Related to the admin menu or tools tools:processes Related to Scripts & Processes (new to DSpace 7) component: Discovery related to discovery search or browse system labels Oct 23, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Oct 23, 2026
@lgeggleston

Copy link
Copy Markdown
Contributor

Hi @aprilherron, thank you for submitting this contribution! Since this is a medium sized change, would you be able to create an issue ticket describing the use case and context for this feature in a little more detail? We can then use that issue to link both PRs and as a place for further discussion. Thanks!

Side note - you may have already noticed, but it looks like this PR is currently not passing one of the unit tests.

@aprilherron

Copy link
Copy Markdown
Author

Thanks @lgeggleston , I've gone ahead and created an issue for the feature request 👍

I did note the failing unit tests and spent some time investigating it ... but the jobs seem to be failing on a line that doesn't even exist in this PR:

Error: src/app/shared/search/search.component.spec.ts:512:13 - error TS2322: Type 'SearchObjects<ListableObject> & { page: (Item & { metadata: { 'dc.title': { language: string; value: string; }[]; }; _links: { self: { href: string; }; }; })[]; pageInfo: PageInfo & { ...; }; }' is not assignable to type 'SearchObjects<DSpaceObject>'.
START:
  The types returned by 'page.pop()' are incompatible between these types.
    Type 'SearchResult<ListableObject>' is not assignable to type 'SearchResult<DSpaceObject>'.
      Type 'ListableObject' is missing the following properties from type 'DSpaceObject': _name, id, uuid, type, and 14 more.

512       const searchResultsPage2: SearchObjects<DSpaceObject> = Object.assign(new SearchObjects(), {

I tried restarting the job, but ran into the same result. The tests seem to work fine for me locally (both Node 20 and 22).

Do you know what might be causing this?

@artlowel
artlowel changed the base branch from main to backport-5610-to-dspace-9_x October 30, 2026 09:05
@artlowel
artlowel changed the base branch from backport-5610-to-dspace-9_x to main October 30, 2026 09:05
@lgeggleston

Copy link
Copy Markdown
Contributor

Hi @aprilherron, thank you for creating the issue ticket!

Hmm good point - I'm not sure at first glance about the failing test, but some possible thoughts:

  • Assuming these frontend changes require the backend changes to fully function - perhaps that's why they are passing locally for you but not on this PR environment. We would just want to confirm that with reviewers if so.
  • Perhaps less likely, but the line mentioned in the error is in search.component.spec.ts, could theoretically be affected by the changes to mockSearchResults down the line since that's part of the setup for a lot of tests

@aprilherron

Copy link
Copy Markdown
Author

I can't find any reason the tests are failing, they pass fine for me locally and I can't understand the error reported above. The tests themselves aren't dependent on any REST work. I'm closing this PR and attempting a new one.

@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to ✅ Done in DSpace 11.0 Release Nov 19, 2026
@aprilherron

Copy link
Copy Markdown
Author

New PR made no difference... still need to resolve testing issue

@aprilherron aprilherron reopened this Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: administrative tools Related to the admin menu or tools component: Discovery related to discovery search or browse system new feature tools:processes Related to Scripts & Processes (new to DSpace 7)

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Searchability of Admin Processes

2 participants