Skip to content

Prevent duplicate submissions on Request a Copy and grant/deny email forms - #6548

Open
chavananand wants to merge 1 commit into
DSpace:mainfrom
chavananand:fix-request-a-copy-double-submit
Open

chavananand wants to merge 1 commit into
DSpace:mainfrom
chavananand:fix-request-a-copy-double-submit

Conversation

@chavananand

Copy link
Copy Markdown

References

Description

Prevents duplicate item requests and duplicate emails when the "Request copy" button, or the "Send" button on the grant/deny email forms, is clicked repeatedly while the request is still in flight.

Instructions for Reviewers

List of changes in this PR:

  • BitstreamRequestACopyPageComponent: added a submitting flag. onSubmit() returns early while a request is pending (or the form is invalid); the "Request copy" button is disabled and shows a spinner while submitting. The flag is reset on failure so the user can retry.
  • GrantRequestCopyComponent / DenyRequestCopyComponent: added a sending flag with the same guard in grant() / deny(), reset on failure.
  • EmailRequestCopyComponent (and its themed wrapper): new sending input. While sending, submit() does nothing, the "Send" and "Back" buttons are disabled, and "Send" shows a spinner.
  • New i18n keys: bitstream-request-a-copy.submitting, grant-deny-request-copy.email.sending.
  • Specs: each guard is tested by calling submit twice against a request that never completes and asserting the service is called once; failure paths assert the flag is reset.

How to test:

  1. Open the Request a Copy form for a restricted bitstream and fill in the required fields.
  2. In DevTools, throttle the network (e.g. "Slow 3G").
  3. Click "Request copy" several times quickly. Only one POST /server/api/core/itemrequests should be sent, and the button should show a spinner and be disabled until the redirect.
  4. Open the grant (or deny) link from the request email, and click "Send" several times quickly with throttling on. Only one request should be sent.
  5. To check retry: block the request URL in DevTools and submit. An error notification should appear and the button should become active again.

Question for reviewers (from the issue discussion): should there also be a backend safeguard in DSpace/DSpace, such as deduplicating identical item requests within a short window, or is the UI in-flight guard sufficient?

AI Disclosure (REQUIRED)

Per our AI Contribution Policy, all contributors to DSpace MUST disclose AI/LLM usage.
This information helps reviewers assess provenance, licensing, security, and the level of verification needed.

If AI tools were ONLY used for incidental assistance (such as spelling/grammar correction, variable auto-completion, or translation), then select 'No'.

Were AI tools used in the creation of this PR?

  • No (This PR does NOT include AI-generated or AI-assisted content that requires disclosure.)
  • Yes (This PR includes AI-generated or AI-assisted content that requires disclosure.)

If "Yes", briefly describe what portion of this PR was generated or assisted by AI. Additionally, tell us how you've verified the AI output aligns with DSpace's coding standards and is secure and accurate.

An AI coding assistant helped draft parts of the patch and the new specs. All changes were reviewed; ESLint reports no errors on the changed files, the affected specs pass locally, and the new in-flight specs were confirmed to fail when the guard is removed.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

…d grant/deny flows

Repeated clicks on the "Request copy" button and on the "Send" button of
the grant and deny email forms fired one REST request per click, creating
duplicate item requests and duplicate notification emails.

Guard each submit with an in-flight flag, disable the button and show a
spinner while the request is pending, and re-enable it when the request
fails so the user can retry.

Fixes DSpace#6541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request a Copy: repeated clicks on submit / send create duplicate requests and emails

1 participant