Repository navigation
Cherry-pick apache/datafusion#24737: cover unsorted contiguous groups - #204
Open
Tristan1900 wants to merge 1 commit into
Open
Tristan1900 wants to merge 1 commit into
Tristan1900 wants to merge 1 commit into
Conversation
Tristan1900
force-pushed
the
wenqi.mou/cherry-pick/apache-pr-24737-20261111
branch
from
November 11, 2026 23:00
b024f06 to
55db7eb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-55 #204 +/- ##
==========================================
Coverage 81.22% 81.23%
==========================================
Files 1111 1111
Lines 389078 389136 +58
Branches 389078 389136 +58
==========================================
+ Hits 316046 316107 +61
+ Misses 54358 54346 -12
- Partials 18674 18683 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Tristan1900
marked this pull request as ready for review
November 12, 2026 18:23
Tristan1900
force-pushed
the
wenqi.mou/cherry-pick/apache-pr-24737-20261111
branch
from
November 12, 2026 18:36
55db7eb to
e9a11d2
Compare
Tristan1900
force-pushed
the
wenqi.mou/cherry-pick/apache-pr-24737-20261111
branch
2 times, most recently
from
November 12, 2026 20:13
1a24291 to
65e53a7
Compare
Tristan1900
changed the base branch from
wenqi.mou/cherry-pick/apache-pr-25019-20261111
to
branch-55
November 12, 2026 20:13
This comment has been minimized.
This comment has been minimized.
geoffreyclaude
approved these changes
Nov 16, 2026
## Which issue does this PR relate to? - Part of apache#24438. ## Rationale for this change A source can concatenate several sorted logical runs into one DataFusion output partition. The resulting stream may be globally unsorted while every distinct `(key, time_bin)` tuple still occupies one contiguous range. This PR records how aggregate planning handles that layout before grouped input properties are available. It provides the behavioral baseline for the remaining PRs in the stack. ## What changes are included in this PR? - Add a single-partition `TestMemoryExec` fixture containing two sorted logical runs whose `(key, time_bin)` order resets at the record-batch boundary. - Aggregate by the complete `(key, time_bin)` tuple and verify the result. - Assert that planning selects `InputOrderMode::Linear`, `EmissionType::Final`, and `SingleHashAggregateStream`. ## Stack 1. [apache#24737 — test: cover unsorted contiguous groups in one partition](apache#24737) ← **this PR** 2. [apache#24697 — refactor: separate aggregate group completion from input ordering](apache#24697) 3. [apache#24698 — feat: add grouped equivalence properties](apache#24698) 4. [apache#24497 — feat: stream aggregates over grouped input](apache#24497) ## Are these changes tested? The new aggregate test executes the single-partition input and snapshot-checks all four grouped sums. ## Are there any user-facing changes? No. ## Review this layer [View only this PR layer](apache@36969e7) (cherry picked from commit 59d74ca)
erik-sargent
force-pushed
the
wenqi.mou/cherry-pick/apache-pr-24737-20261111
branch
from
November 16, 2026 18:41
65e53a7 to
c8fd71b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.