[dougqh]

What Does This Do

Sets database span tags with KnownTags ids instead of names, in two places:

• DatabaseClientDecorator, which every database client's spans go through (JDBC, Redis, Mongo, Cassandra, ...): db.user, peer.hostname, db.instance, db.type.
• JDBC:
  • db.operation, db.warehouse, db.schema, db.pool.name, component
  • _dd.propagated_hash, _dd.dbm_trace_injected, _dd.instrumentation.time_ms
  • JDBCDecorator.setTagIfPresent now takes the id. All of its callers passed constants.
  • The one "_dd.dbm_trace_injected" string literal becomes the same id as its constant.

Motivation

This continues the move to ids after Kafka (#13192). Every one of these tags was already registered, so the change is mechanical. The decorator part benefits every database client, not just JDBC.

Additional Notes

• No behavior change. For a known tag, the core span's setTag(String, …) resolves the name and calls setTag(long, …). This PR calls the id setter directly, so storage and interception are unchanged.
• Left as is: .withTag("dd.instrumentation", true) on the span builder. The builder has no id-keyed withTag yet, and dd.instrumentation isn't registered.
• Stacked on Name KnownTags ids after their tags and fail on constant clashes (tag registry rollout) #13061, for its bare id names (DB_POOL_NAME). It doesn't depend on Set Kafka span tags by id (tag registry rollout) #13192.
• Testing:
  • agent-bootstrap decorator tests pass (414). Their Spock mocks still match string-keyed setTag assertions, because the id default method delegates to the name.
  • jdbc test: 328 pass. The other 100 are RemoteJDBCInstrumentationV0Test, which needs Docker (Testcontainers) and couldn't run locally. CI will cover them.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-03T22:41:15.105330Z	67bb80a	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[datadog-prod-us1-4]

More details

The registered IDs match the existing database and JDBC tag keys and preserve setter overloads, null handling, and tag interception.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 67bb80a}

[datadog-prod-us1-4]

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.99% (+0.00%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 08dac0f | Docs | Give us feedback!}

[dd-octo-sts]

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.97 s	13.92 s	[-0.3%; +1.0%] (no difference)
startup:insecure-bank:tracing:Agent	12.89 s	12.94 s	[-1.2%; +0.4%] (no difference)
startup:petclinic:appsec:Agent	17.21 s	17.07 s	[+0.1%; +1.4%] (maybe worse)
startup:petclinic:iast:Agent	16.40 s	16.61 s	[-7.3%; +4.8%] (unstable)
startup:petclinic:profiling:Agent	16.70 s	16.83 s	[-1.9%; +0.3%] (no difference)
startup:petclinic:sca:Agent	17.10 s	17.00 s	[-0.4%; +1.6%] (no difference)
startup:petclinic:tracing:Agent	15.78 s	16.21 s	[-6.9%; +1.6%] (no difference)

Commit: 08dac0f7 · CI Pipeline · Benchmarking Platform UI

---

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

[ygree]

IDM approved

[datadog-prod-us1-4]

The new collision policy rejects the existing shared plugin fixture, breaking build-plugin verification. The constant rename also silently narrows the bucket-hash checks to tags whose names still end in _ID.

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit d82541c}

---

Findings that could not be posted inline

build-logic/tag-registry/src/main/kotlin/datadog/buildlogic/tagRegistry/KnownTagsEmitter.kt:36

Adapt the shared plugin fixture to the new collision policy

TagRegistryGeneratorPluginTest's shared fixture still declares both foo and foo.name. These now claim FOO_NAME as a string constant and an ID respectively, causing generation to throw before the existing compilation, cache, and custom-output assertions. Update the shared fixture or provide a java_names override alongside this collision-policy change.

React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it

What each reaction means

• 👍 Useful: correct, and you're fixing it or will.
• 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
• 😕 Unclear: you can't tell what it means or why it matters.
• 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.

_{🤖 Bits Code Review · Open Bits AI session}

build-logic/tag-registry/src/main/kotlin/datadog/buildlogic/tagRegistry/KnownTagsEmitter.kt:47

Update bucket-hash ID enumeration for the removed suffix

TagMapBucketHashTest.knownTagIds() still selects reflected long fields whose names end in _ID. After this rename, it only includes tags whose names naturally have that suffix, silently excluding tags such as HTTP_METHOD and HTTP_ROUTE from the distinct-hash and slot-bucketing checks. Remove the suffix predicate in that helper to preserve coverage of all generated IDs.

React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it

What each reaction means

• 👍 Useful: correct, and you're fixing it or will.
• 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
• 😕 Unclear: you can't tell what it means or why it matters.
• 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.

_{🤖 Bits Code Review · Open Bits AI session}

[datadog-prod-us1-4]

Renaming generated tag constants leaves the bucket-hash tests filtering by the old _ID suffix, silently excluding database and HTTP tags from their checks.

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 7ebc223}

---

Findings that could not be posted inline

build-logic/tag-registry/src/main/kotlin/datadog/buildlogic/tagRegistry/KnownTagsEmitter.kt:47

Preserve full tag enumeration in the bucket-hash tests

After this rename, TagMapBucketHashTest.knownTagIds() still requires field names ending in "_ID", so it selects only 16 of 330 tags and omits every database and HTTP tag. The uniqueness and slot-placement checks therefore keep passing without exercising most of the registry. Update that helper to select static long fields independently of their names.

React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it

What each reaction means

• 👍 Useful: correct, and you're fixing it or will.
• 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
• 😕 Unclear: you can't tell what it means or why it matters.
• 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.

_{🤖 Bits Code Review · Open Bits AI session}

[dougqh]

/merge

[gh-worker-devflow-routing-ef8351]

View all feedbacks in Devflow UI.

2026-11-06 18:36:37 UTC ℹ️ Start processing command /merge

---

2026-11-06 18:36:42 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

---

2026-11-06 19:44:41 UTC ℹ️ MergeQueue: This merge request was merged