Skip to content

Remove legacy property support in test jvm constraints plugin - #13206

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
bdu/fix-test-jvm-include-inheritance
Nov 5, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
bdu/fix-test-jvm-include-inheritance

Conversation

@bric3

@bric3 bric3 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Complete the migration from legacy constraint properties to the testJvmConstraints extension. Make test tasks respect project-level testJvmConstraints.includeJdk (no project were impacted before).

Motivation

Completing the migration removes the remaining compatibility code and gives JVM constraints a single configuration mechanism, wjhich was the original intended purpose.

Additional Notes

Debugger agent applied the reflective access, that could be looked up by subprojects in the previous code. Now the reflective access toggle is explicit in projects that need it : agent-debugger and debugger-bootstrap.

Contributor Checklist

@bric3 bric3 added tag: ai generated Largely based on code generated by an AI or LLM comp: tooling Build & Tooling type: bug fix Bug fix tag: no release notes Changes to exclude from release notes labels Nov 4, 2026 — with ChatGPT Codex Connector
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.92% (-0.04%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7ab4682 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.86 s 14.63 s [+0.9%; +2.4%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.70 s 13.71 s [-0.9%; +0.8%] (no difference)
startup:petclinic:appsec:Agent 17.16 s 16.95 s [+0.3%; +2.1%] (maybe worse)
startup:petclinic:iast:Agent 16.99 s 16.92 s [-0.5%; +1.3%] (no difference)
startup:petclinic:profiling:Agent 16.18 s 16.77 s [-7.7%; +0.7%] (no difference)
startup:petclinic:sca:Agent 17.15 s 16.94 s [+0.3%; +2.2%] (maybe worse)
startup:petclinic:tracing:Agent 16.17 s 15.79 s [-1.8%; +6.7%] (no difference)

Commit: 7ab46821 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@pr-commenter

pr-commenter Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1793809184 1793809511
end_time 2026-11-04T16:21:15 2026-11-04T16:26:42
git_branch master bdu/fix-test-jvm-include-inheritance
git_commit_sha efd33e6 7ab4682
start_time 2026-11-04T16:19:45 2026-11-04T16:25:12
See matching parameters
Baseline Candidate
ci_job_id 2212667571 2212667571
ci_pipeline_id 150222940 150222940
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
git_commit_date 1793808150 1793808150

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-20.609µs; +29.959µs] or [-6.172%; +8.973%]
unstable
[-33.028µs; +41.386µs] or [-8.965%; +11.234%]
unstable
[-41.807µs; +49.576µs] or [-10.922%; +12.951%]
unstable
[-73.948µs; +143.309µs] or [-6.575%; +12.742%]
same
scenario:basic same same same unstable
[-131.177µs; +159.292µs] or [-14.360%; +17.437%]
same
scenario:loop same same same same same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (368.405 µs) : 339, 398
.   : milestone, 368,
basic (350.505 µs) : 345, 356
.   : milestone, 351,
loop (8.123 ms) : 8059, 8188
.   : milestone, 8123,
section candidate
noprobe (372.584 µs) : 332, 413
.   : milestone, 373,
basic (347.622 µs) : 342, 354
.   : milestone, 348,
loop (8.119 ms) : 8055, 8182
.   : milestone, 8119,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 368.405 µs [338.817 µs, 397.993 µs]
basic 350.505 µs [345.103 µs, 355.907 µs]
loop 8.123 ms [8.059 ms, 8.188 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 372.584 µs [332.332 µs, 412.836 µs]
basic 347.622 µs [341.624 µs, 353.619 µs]
loop 8.119 ms [8.055 ms, 8.182 ms]

@bric3 bric3 changed the title Apply project JVM inclusion constraints to test tasks Remove legacy property support in test jvm constraints plugin Nov 4, 2026
@bric3
bric3 marked this pull request as ready for review November 4, 2026 13:04
@bric3
bric3 requested review from a team as code owners November 4, 2026 13:04
@bric3
bric3 requested review from amarziali and removed request for a team November 4, 2026 13:04
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T13:06:53.339560Z 7addc0d Draft marked ready
🔒 Security Review ✅ Completed 2026-11-04T13:06:53.435491Z 7addc0d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bric3
bric3 requested a review from jpbempel November 4, 2026 13:04

@datadog-prod-us1-4 datadog-prod-us1-4 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Static review supports the project-level includeJdk inheritance while preserving explicit task overrides. The remaining legacy configurations have extension-based replacements, with no actionable defects identified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 7addc0d

@bric3
bric3 requested a review from PerfectSlayer November 4, 2026 14:58
@bric3
bric3 force-pushed the bdu/fix-test-jvm-include-inheritance branch from 7addc0d to 7ab4682 Compare November 4, 2026 16:03
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit e8b0fd4 into master Nov 5, 2026
697 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/fix-test-jvm-include-inheritance branch November 5, 2026 10:55
@github-actions github-actions Bot added this to the 1.69.0 milestone Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants