Repository navigation
Conversation
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
Static review found that Lambda client-IP resolution matches the existing HTTP configuration gates and address precedence, and publishes the inferred address before the socket callback can trigger WAF evaluation.
🤖 Bits Code Review · Commit ce4a747
jandro996
left a comment
There was a problem hiding this comment.
I've added some non-blocking comments
There was a problem hiding this comment.
The resolver relocation leaves its comprehensive tests in another module, breaking internal-api’s enforced per-class coverage gate. Those tests need to move with the production classes.
🤖 Bits Code Review · Commit 4506543
There was a problem hiding this comment.
praise: thx for the migration
What Does This Do
Give Java Lambda ATO and SDK events the same client-IP context as HTTP server integrations, respecting the existing resolution settings. Publish the inferred IP before request evaluation.
Motivation
Login and custom-event tracking in Lambda need client-IP information for ATO support without introducing an agent-bootstrap dependency into dd-trace-core.
Additional Notes
ClientIpAddressResolver and its parsing helper now live in internal-api. HTTP and Lambda share header/peer precedence; an invalid peer preserves a valid header address.
Validation: 475 targeted resolver, HTTP, Lambda, and standalone-jar tests passed. Agent packaging and formatting passed. Companion system-tests PR: DataDog/system-tests#8352.
Exploratory JMH results before this refactor showed approximately 0.05–0.23 µs added for source/forwarded/malformed inputs and 1.1 µs for a 32-hop chain. These measure request-start processing once per invocation, excluding WAF and I/O. Benchmark files are excluded from this PR.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-71107