Skip to content

Add SKIP_BUILD_CACHE as CI option via commit message - #13220

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
sarahchen6/add-ci-option
Nov 5, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
sarahchen6/add-ci-option

Conversation

@sarahchen6

@sarahchen6 sarahchen6 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

If [ci: *SKIP_BUILD_CACHE*] is in the commit message, then force fresh Gradle task execution. This is ignored in publication stages to avoid publishing separately build artifacts.

Motivation

Fresh Gradle task execution can be useful when diagnosing failures with reused outputs. The GitLab caches still remain available.

Additional Notes

Contributor Checklist

Jira ticket: https://datadoghq.atlassian.net/browse/APMLP-1897

@sarahchen6
sarahchen6 requested review from a team as code owners November 4, 2026 18:54
@sarahchen6 sarahchen6 added the type: feature Enhancements and improvements label Nov 4, 2026
@sarahchen6
sarahchen6 removed the request for review from a team November 4, 2026 18:54
@sarahchen6 sarahchen6 added the tag: no release notes Changes to exclude from release notes label Nov 4, 2026
@sarahchen6 sarahchen6 added the comp: tooling Build & Tooling label Nov 4, 2026
@sarahchen6
sarahchen6 requested review from erikayasuda and removed request for a team November 4, 2026 18:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T18:55:54.972277Z d06027e PR opened
🔒 Security Review ✅ Completed 2026-11-04T18:57:34.687610Z d06027e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Combined directives such as [ci: ARM64, SKIP_BUILD_CACHE] enable fresh Gradle task execution while preserving the existing environment-variable override. The reviewer’s targeted checks covered case sensitivity and nonmatching messages without identifying a defect.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit d06027e

@sarahchen6
sarahchen6 requested a review from bric3 November 4, 2026 19:49
Comment thread AGENTS.md Resolved
@bric3 bric3 changed the title Add SKIP_BUILD_CACHE as CI option via commit message Add SKIP_BUILD_CACHE as CI option via commit message Nov 5, 2026

@bric3 bric3 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the reader: I think this is important to consider SKIP_BUILD_CACHE as a opt-in diagnostic falg. While potentially useful, it has the following behavior that may not be suitable for daily use or release.

  • validate_build

    In #12604 this job is a matrix that validates both runs with build cache and without. But having SKIP_BUILD_CACHE make validate_build always run without build cache (whioch can be confusing).

    i.e. the matrix no longer covers cached versus uncached.

  • Runtime impact

    Today there's no shared Gradle build cache across pipelines, it's being worked one as part of #12604. What happens today, i.e. before #12604, GitLab passes prepared outputs between jobs within a pipeline using archives keyed by $CI_PIPELINE_ID-$CACHE_TYPE.

    The initial build and build_tests jobs could push to these gitlab cache. But when the S3 Build cache will be enabled, this intra pipeline won't be available either, forcing additional work downstream:

    • Jobs will have to do again compilation, code generation, packaging and other selected build dependencies that would normally reuse previous outputs.
    • The runtime cost depends on each job's usual reuse. Pipeline duration also depends on whether the affected jobs are on the critical path.
    • Note that dependencies and plugin caches remain available, because they are GitLab cache which is untouched by the S3 Build cache changes in #12604.
  • Publishing risk

    If a master or release pipeline builds a commit with SKIP_BUILD_CACHE, the deploy_to_maven_central job will then also receives --no-build-cache --rerun-tasks. And its publishToSonatype invocation forces the archive-producing tasks to execute again.

    And unfortunately the validate_build comparison won;t cover properly the files produced by that publication rebuild anymore. In short : if output is non-deterministic, the published artifacts can differ from the compared artifacts.

    Maybe excluding publication from the commit-message could help, or even disabling all publication jobs.

Comment thread AGENTS.md Resolved
Comment thread .gitlab-ci.yml Resolved
Comment thread .gitlab-ci.yml Resolved
Comment thread docs/how_to_work_with_gradle.md Resolved
Comment thread docs/how_to_work_with_gradle.md Resolved
Comment thread docs/how_to_work_with_gradle.md Resolved
@datadog-datadog-prod-us1

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.96 s 13.81 s [+0.5%; +1.8%] (maybe worse)
startup:insecure-bank:tracing:Agent 12.92 s 13.00 s [-1.4%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 17.21 s 17.13 s [-0.3%; +1.3%] (no difference)
startup:petclinic:iast:Agent 16.97 s 17.04 s [-1.1%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.62 s 16.97 s [-3.3%; -0.9%] (maybe better)
startup:petclinic:sca:Agent 17.08 s 17.06 s [-0.8%; +1.0%] (no difference)
startup:petclinic:tracing:Agent 16.17 s 16.16 s [-0.8%; +0.9%] (no difference)

Commit: d3cff355 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@sarahchen6

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-11-05 19:14:57 UTC ℹ️ Start processing command /merge


2026-11-05 19:15:02 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-11-05 20:22:08 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 7b0dfea into master Nov 5, 2026
914 of 916 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the sarahchen6/add-ci-option branch November 5, 2026 20:22
@github-actions github-actions Bot added this to the 1.69.0 milestone Nov 5, 2026
@bric3 bric3 mentioned this pull request Nov 6, 2026
8 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants