Skip to content

Update Spotless to 8.11.0 and use formatter defaults - #13225

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
alexeyk/update-spotless-8.11.0
Nov 5, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
alexeyk/update-spotless-8.11.0

Conversation

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

What Does This Do

Update Spotless from 8.10.4 to 8.11.0 and apply Google Java Format 2.0.0 using its default 100-column limit.

Drop the Google Java Format, ktlint, and scalafmt versions from the catalog: Spotless now supplies the versions we want (2.0.0, 1.8.0, and 3.11.5 respectively). Keep GrEclipse 4.27 pinned to preserve Spock formatting, and TableTest Formatter 1.1.3 because Spotless still defaults to 1.1.2.

Motivation

Use the updated formatter and let Spotless maintain matching formatter defaults, instead of duplicating those versions in our catalog.

Additional Notes

Spotless 8.11.0 adds googleJavaFormat().maxLineLength(int). Trying maxLineLength(120) did more harm than good for readability here: it collapsed useful method-chain layouts and introduced much broader formatting churn. The default 100 is much better for this codebase, so this PR uses googleJavaFormat() without an override. Google Java Format still decides wrapping itself; 100 columns does not guarantee that every chain stays expanded.

Two examples from IastExtension, verified with Google Java Format 2.0.0:

At 120 columns:

return Stream.of("Before", "Around", "After").map(method::getAnnotationByName).anyMatch(Optional::isPresent);

At the default 100 columns:

return Stream.of("Before", "Around", "After")
    .map(method::getAnnotationByName)
    .anyMatch(Optional::isPresent);

At 120 columns:

enableTelemetryBody.addStatement(
    new AssignExpr().setTarget(accessLocalField("verbosity")).setValue(new NameExpr("verbosity")));

At the default 100 columns:

enableTelemetryBody.addStatement(
    new AssignExpr()
        .setTarget(accessLocalField("verbosity"))
        .setValue(new NameExpr("verbosity")));

The remaining source changes are generated formatting, including the new lambda layout and removal of redundant annotation/lambda parentheses and semicolons. This makes the diff larger than a typical PR; no tracer behavior changes are intended. Formatter artifacts are not tracked in the project dependency lockfiles, so no lockfile updates are needed.

Validation:

  • ./gradlew spotlessCheck
  • ./gradlew -p buildSrc :call-site-instrumentation-plugin:test :modifiable-config-agent:test -PrunBuildSrcTests
  • ./gradlew -p build-logic :tag-registry:test
  • git diff --check

Precedent: Update Spotless to 8.10.4; this also preserves the alignment between the shared configuration and the Spotless predeclare DSL.

Contributor Checklist

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added tag: no release notes Changes to exclude from release notes type: refactoring tag: dependencies Dependencies related changes comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM labels Nov 4, 2026
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD marked this pull request as ready for review November 4, 2026 19:35
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from a team as code owners November 4, 2026 19:35
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from bric3, claponcet, jpbempel and ygree and removed request for a team November 4, 2026 19:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T19:38:27.444652Z d543d32 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-04T19:39:44.543571Z d543d32 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from manuel-alvarez-alvarez and mcculls and removed request for a team November 4, 2026 19:35
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Nov 4, 2026

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Source token comparisons identified only formatting, comment changes, and removal of redundant parentheses and semicolons. Formatter defaults match the intended versions, and configuration remains consistent across builds.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit d543d32

@pr-commenter

pr-commenter Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1793902412 1793902738
end_time 2026-11-05T18:15:00 2026-11-05T18:20:26
git_branch master alexeyk/update-spotless-8.11.0
git_commit_sha f446774 5460af1
start_time 2026-11-05T18:13:33 2026-11-05T18:18:59
See matching parameters
Baseline Candidate
ci_job_id 2219022383 2219022383
ci_pipeline_id 150674248 150674248
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1793901482 1793901482

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-30.209µs; +39.554µs] or [-9.438%; +12.357%]
unstable
[-43.544µs; +55.195µs] or [-12.358%; +15.665%]
unstable
[-52.174µs; +67.828µs] or [-14.260%; +18.539%]
unstable
[-88.084µs; +324.299µs] or [-7.499%; +27.608%]
same
scenario:basic same same same unstable
[-230.523µs; +26.593µs] or [-19.083%; +2.201%]
unstable
[-204.940op/s; +99.231op/s] or [-8.812%; +4.267%]
scenario:loop same same same same same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (352.343 µs) : 315, 389
.   : milestone, 352,
basic (327.374 µs) : 320, 334
.   : milestone, 327,
loop (8.088 ms) : 8024, 8152
.   : milestone, 8088,
section candidate
noprobe (358.168 µs) : 303, 413
.   : milestone, 358,
basic (325.678 µs) : 320, 331
.   : milestone, 326,
loop (8.088 ms) : 8025, 8151
.   : milestone, 8088,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 352.343 µs [315.49 µs, 389.196 µs]
basic 327.374 µs [320.498 µs, 334.249 µs]
loop 8.088 ms [8.024 ms, 8.152 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 358.168 µs [303.011 µs, 413.326 µs]
basic 325.678 µs [320.065 µs, 331.29 µs]
loop 8.088 ms [8.025 ms, 8.151 ms]

@datadog-official

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.03 s 13.98 s [-0.4%; +1.0%] (no difference)
startup:insecure-bank:tracing:Agent 12.86 s 12.97 s [-1.6%; -0.1%] (maybe better)
startup:petclinic:appsec:Agent 17.02 s 16.51 s [-1.4%; +7.5%] (no difference)
startup:petclinic:iast:Agent 16.92 s 16.54 s [-2.0%; +6.6%] (no difference)
startup:petclinic:profiling:Agent 16.09 s 16.76 s [-8.0%; +0.0%] (no difference)
startup:petclinic:sca:Agent 16.89 s 16.35 s [-0.8%; +7.5%] (no difference)
startup:petclinic:tracing:Agent 16.13 s 15.78 s [-2.1%; +6.4%] (no difference)

Commit: 5460af1c · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@ygree ygree left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDM reviewed

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only checked the new conf and glances at the formatting impact. So far it looks better indeed.

@mcculls mcculls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thanks!

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/merge -@ 1 hour

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-11-05 15:55:34 UTC ℹ️ Start processing command /merge -@ 1 hour


2026-11-05 15:55:37 UTC ℹ️ MergeQueue: merge request scheduled for Thu, 05 Nov 2026 16:55:34 UTC

Pull Request scheduled to be added to the queue on Thu, 05 Nov 2026 16:55:34 UTC


2026-11-05 16:56:02 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-11-05 17:16:42 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 95e701b:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/merge -f --reason "No need to run MQ, validated in PR"

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-11-05 20:30:26 UTC ℹ️ Start processing command /merge -f --reason "No need to run MQ, validated in PR"


2026-11-05 20:30:30 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 0s (p90).


2026-11-05 20:30:44 UTC ℹ️ MergeQueue: This merge request was merged

Warning

This change was merged without running any pre merge CI checks

Reason: No need to run MQ, validated in PR

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit acf734f into master Nov 5, 2026
697 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the alexeyk/update-spotless-8.11.0 branch November 5, 2026 20:30
@github-actions github-actions Bot added this to the 1.69.0 milestone Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: dependencies Dependencies related changes tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants