Repository navigation
Update Spotless to 8.11.0 and use formatter defaults - #13225
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
Source token comparisons identified only formatting, comment changes, and removal of redundant parentheses and semicolons. Formatter defaults match the intended versions, and configuration remains consistent across builds.
🤖 Bits Code Review · Commit d543d32
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (352.343 µs) : 315, 389
. : milestone, 352,
basic (327.374 µs) : 320, 334
. : milestone, 327,
loop (8.088 ms) : 8024, 8152
. : milestone, 8088,
section candidate
noprobe (358.168 µs) : 303, 413
. : milestone, 358,
basic (325.678 µs) : 320, 331
. : milestone, 326,
loop (8.088 ms) : 8025, 8151
. : milestone, 8088,
|
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
PerfectSlayer
left a comment
There was a problem hiding this comment.
I only checked the new conf and glances at the formatting impact. So far it looks better indeed.
|
/merge -@ 1 hour |
|
View all feedbacks in Devflow UI.
Pull Request scheduled to be added to the queue on Thu, 05 Nov 2026 16:55:34 UTC
The expected merge time in
Build pipeline has failing jobs for 95e701b: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
|
/merge -f --reason "No need to run MQ, validated in PR" |
|
View all feedbacks in Devflow UI.
The expected merge time in
Warning This change was merged without running any pre merge CI checks Reason: No need to run MQ, validated in PR |
What Does This Do
Update Spotless from 8.10.4 to 8.11.0 and apply Google Java Format 2.0.0 using its default 100-column limit.
Drop the Google Java Format, ktlint, and scalafmt versions from the catalog: Spotless now supplies the versions we want (2.0.0, 1.8.0, and 3.11.5 respectively). Keep GrEclipse 4.27 pinned to preserve Spock formatting, and TableTest Formatter 1.1.3 because Spotless still defaults to 1.1.2.
Motivation
Use the updated formatter and let Spotless maintain matching formatter defaults, instead of duplicating those versions in our catalog.
Additional Notes
Spotless 8.11.0 adds
googleJavaFormat().maxLineLength(int). TryingmaxLineLength(120)did more harm than good for readability here: it collapsed useful method-chain layouts and introduced much broader formatting churn. The default100is much better for this codebase, so this PR usesgoogleJavaFormat()without an override. Google Java Format still decides wrapping itself; 100 columns does not guarantee that every chain stays expanded.Two examples from
IastExtension, verified with Google Java Format 2.0.0:At 120 columns:
At the default 100 columns:
At 120 columns:
At the default 100 columns:
The remaining source changes are generated formatting, including the new lambda layout and removal of redundant annotation/lambda parentheses and semicolons. This makes the diff larger than a typical PR; no tracer behavior changes are intended. Formatter artifacts are not tracked in the project dependency lockfiles, so no lockfile updates are needed.
Validation:
./gradlew spotlessCheck./gradlew -p buildSrc :call-site-instrumentation-plugin:test :modifiable-config-agent:test -PrunBuildSrcTests./gradlew -p build-logic :tag-registry:testgit diff --checkPrecedent: Update Spotless to 8.10.4; this also preserves the alignment between the shared configuration and the Spotless predeclare DSL.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue