Repository navigation
Conversation
JSON Patch operations on the root path "" call overwrite_item(), which freed root->string, root->valuestring and root->child unconditionally, ignoring cJSON_IsReference and cJSON_StringIsConst. After a root replace/add, object->string was also freed unconditionally although cJSON_Duplicate() keeps a constant key by pointer. Applying such a patch to a reference item or to an item with a constant key freed memory the item does not own (double free / use-after-free / invalid free). - overwrite_item(): free only what the item owns, as cJSON_Delete() does. - After a root replace/add, do not free a constant key and clear cJSON_StringIsConst. - Add five regression tests to tests/misc_utils_tests.c. CVE-2026-117448 Reported by Rachid Marcil (gsmarcil).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON Patch operations on the root path "" call overwrite_item(), which freed root->string, root->valuestring and root->child unconditionally, ignoring cJSON_IsReference and cJSON_StringIsConst. After a root replace/add, object->string was also freed unconditionally although cJSON_Duplicate() keeps a constant key by pointer.
Applying such a patch to a reference item or to an item with a constant key freed memory the item does not own (double free / use-after-free / invalid free).
CVE-2026-117448
Reported by Rachid Marcil (gsmarcil).