Repository navigation
fix(session): defer release until pending transactions finish - #178
Merged
shuk777 merged 1 commit intoNov 16, 2026
Merged
Conversation
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Deferred release currently uses inconsistent conditions.
request_releasewaits for active uses and pending transactions, butend_usecan free KV storage while a transaction is still pending. Conversely, committing or interrupting a transaction never completes an already-requested release when no outer use remains.Wait for both active uses and pending updates before cleanup, and finish deferred release when a commit or interruption clears the last update. The release callback still runs once.
Area
edge0-infer/)How was it tested?
Built
moe_test_session_transactionsand ranctest --preset cpu -R '^moe_test_session_transactions$'on CPU: passed. The new regression fails against the base revision.The six added lifecycle cases combine an optional outer use with commit, pre-submit interruption, and post-submit interruption. They verify that KV storage remains allocated while the update is pending, cleanup runs exactly once, and the budget returns to zero immediately after resolution.
The CPU build uses diagnostic demotions for pre-existing GCC 14 warnings; no external model assets are required.
Checklist