Skip to content

Using of the term entropy is unconsistent and misleading #253

Open

Description

@Sosthene00

Functions like wally_tx_add_elements_raw_input are expecting entropy as an argument. The doc says that this is "Entropy for the asset tag calculation."

The man for wally_tx_elements_issuance_generate_entropy says "Calculate the asset entropy from a prevout and the Ricardian contract hash."

Actually entropy in wally_tx_add_elements_raw_input is contract_hash argument to wally_tx_elements_issuance_generate_entropy.

I think this is all very confusing, and I suggest at least to mention explicitly what is expected as entropy here.

Or maybe clarify variable names.

Activity

  1. jgriffiths commented on Dec 3, 2020

    @jgriffiths
    Contributor

    @Sosthene00 I agree this is confusing. Once the elements PSBT support is finalised in the elements codebase, and #218 updated to reflect it, I hope to standardise the naming between elements txs and the PSBT code since this will be an API change anyway.

    If you encounter any other specific examples that caused you confusion please feel free to document them here and I'll try to make sure they are covered under that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions