Repository navigation
Conversation
`--min-capacity-sat` was parsed with strtoull() and never range-checked, so a value above UINT64_MAX/1000 (or "-1", which strtoull wraps to UINT64_MAX) was accepted at startup and by `setconfig`. The next channel
open, ours or a peer's, then hit:
lightningd: amount_msat overflow for config.min_capacity_sat
lightningd: FATAL SIGNAL 6
in channel_config(). For our own `fundchannel` the inputs had already been reserved by `fundpsbt reserve=2016`, so every attempt also left them locked for 2016 blocks.
Check the value converts to msat when parsing it, so it is refused at startup and by `setconfig` instead.
Changelog-Fixed: lightningd: `min-capacity-sat` values which overflow when converted to msat (including `-1`) are now rejected at startup and by `setconfig`, instead of crashing the node on the next channel open.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--min-capacity-satwas parsed with strtoull() and never range-checked, so a value above UINT64_MAX/1000 (or "-1", which strtoull wraps to UINT64_MAX) was accepted at startup and bysetconfig. The next channel open, ours or a peer's, then hit:in channel_config(). For our own
fundchannelthe inputs had already been reserved byfundpsbt reserve=2016, so every attempt also left them locked for 2016 blocks.Check the value converts to msat when parsing it, so it is refused at startup and by
setconfiginstead.Changelog-Fixed: lightningd:
min-capacity-satvalues which overflow when converted to msat (including-1) are now rejected at startup and bysetconfig, instead of crashing the node on the next channel open.