Remove NO_ID_FIELD key from data hooks #295

Activity

1. jamesdaniels

   added

   enhancement

   on Dec 5, 2020
2. jamesdaniels

   added this to the 3.0.0 milestone on Dec 10, 2020
3. SabrinaDanielle commented on Dec 13, 2020

   

   SabrinaDanielle

   on Dec 13, 2020

   More actions

   Hello, I think my issue may be slightly unrealtated; however, when following the example in the quickstart, instead of getting a boolean value I get "{NO_ID_FIELD: undefined}".

   👍React with 👍1Reacted by Ryan Littlefield
4. SabrinaDanielle commented on Dec 13, 2020

   

   SabrinaDanielle

   on Dec 13, 2020

   Last edited by SabrinaDanielle

   More actions

   import React from "react";
   import { useFirestoreDocData, useFirestore, SuspenseWithPerf } from "reactfire";
   
   const Products = () => {
     const burritoRef = useFirestore().collection("tryreactfire").doc("burrito");
     // subscribe to a document for realtime updates. just one line!
     const burrito = useFirestoreDocData(burritoRef);
   
     if (burrito.status === "loading") {
       return <p>Fetching burrito flavor...</p>;
     }
   
     return (
       <SuspenseWithPerf
         fallback={<p>"Loading store stuff..."</p>}
         traceId={"Loading Store"}
       >
         <div>
           Products
           <p>
             The burrito is
             {burrito.yummy ? "good" : "bad"}!
           </p>
         </div>
       </SuspenseWithPerf>
     );
   };
   
   export default Products;
5. maxprilutskiy commented on Dec 30, 2020

   

   maxprilutskiy

   on Dec 30, 2020

   Contributor

   More actions

   @jhuleatt Jeff, in that case, how do we get the id of a created document, when it's generated by Firebase?
   I believe it makes sense to still have something like _uid attached to docs.
6. jhuleatt commented on Jan 6, 2021

   

   jhuleatt

   on Jan 6, 2021

   CollaboratorAuthor

   More actions

   @SabrinaDanielle it looks like the quickstart code is outdated, apologies for that. I filed #321 to fix the quickstart.

   👍React with 👍2Reacted by Sabrina Danielle Green and Luke Ramus
7. devth commented on Mar 8, 2021

   

   devth

   on Mar 8, 2021

   More actions

   Agree, why not default it to _id or something? Alternatively, let users set a global default so we don't have to keep passing { idField: "id" } on all useFirestoreCollectionData calls.

   👍React with 👍4Reacted by Mahesh Warrier, Ian G, Míla Kuchta and Anthony Boyd
8. cd-a commented on Mar 21, 2021

   

   cd-a

   on Mar 21, 2021

   More actions

   I agree with this. I'm even fine with keeping the current behaviour, as long as we have a way of omitting the id field completely.

   We don't always need it. If I target a specific document only, I already know the Id, otherwise I can't target it. So having that field in there makes me have to filter it out every time i want to use the data.

   👍React with 👍2Reacted by Pras Velagapudi and Anthony Boyd
9. tyler-reitz

   added

   v5Planned for v5Planned for v5

   on Jul 14, 2026
10. tyler-reitz

    closed this as completedin #738on Jul 23, 2026
11. FirebaseExtended

    locked and limited conversation to collaborators on Aug 23, 2026