Skip to content

Change quickstart to support stable builds of React - #326

Merged
jhuleatt merged 6 commits into
mainfrom
new-quickstart
Feb 18, 2021
Merged

jhuleatt merged 6 commits into
mainfrom
new-quickstart

Conversation

@jhuleatt

@jhuleatt jhuleatt commented Jan 14, 2021 •

Copy link
Copy Markdown
Collaborator

Fixes #321

Description

Remove concurrent mode features from quickstart so that it works with stable builds of React

@google-cla google-cla Bot added the cla: yes label Jan 14, 2021
Base automatically changed from master to main January 20, 2021 19:11
@jhuleatt
jhuleatt requested a review from davideast January 20, 2021 19:21
@ngocdaothanh

Copy link
Copy Markdown

@jhuleatt I'm new to reactfire. I've read the code in your PR. Can you please explain why in docs/quickstart.md you write this:

const { status, data } = useFirestoreDocData(burritoRef);

But in docs/quickstart-concurrent-mode.md you write this:

const burrito = useFirestoreDocData(burritoRef);

Why the same function useFirestoreDocData returns 2 different results?

@jhuleatt
jhuleatt merged commit 252b607 into main Feb 18, 2021
@jhuleatt
jhuleatt deleted the new-quickstart branch February 18, 2021 18:54
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update quickstart to 3.x api

2 participants