Repository navigation
Conversation
The unfold contract is only visible in the implementation and tests. Add a user-guide page that explains: - the unfolder class, initial_value(), and the predicate/unfold loop, including the accepted callable forms and the optional child data_cell_index argument - per-parent calls, child numbering, empty parents, and why there is no way to skip a candidate - that all input selectors must name the same layer (rejected since v0.4.3, see issue Framework-R-D#955) and the transform-then-unfold workaround - where resource<T>{} arguments go (issue Framework-R-D#946) Also add a Doxygen description of graph_proxy::unfold, and point api/graph_proxy.rst at phlex::detail::graph_proxy, where the class actually lives, so its documentation is rendered. Assisted by: Claude Haiku 5.5
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1028 +/- ##
==========================================
- Coverage 89.65% 89.50% -0.16%
==========================================
Files 177 177
Lines 5996 5996
Branches 994 994
==========================================
- Hits 5376 5367 -9
- Misses 392 399 +7
- Partials 228 230 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unfold contract is only visible in the implementation and tests. Add a user-guide page that explains:
Also add a Doxygen description of graph_proxy::unfold, and point api/graph_proxy.rst at phlex::detail::graph_proxy, where the class actually lives, so its documentation is rendered.
Assisted by: Claude Haiku 5.5