[knoepfel]

Extend regression coverage for registrar failures, join receiver lookup, and duplicate resource registration.

Aided by GPT-6.1 Sol

• Tests: Added regression coverage for registrar creator exceptions, including single invocation and clean destruction.
• Tests: Expanded join coverage for invalid receiver indices, selector-based receiver lookup, input readiness, selector order, and index-port metadata.
• Tests: Strengthened duplicate resource registration checks to confirm duplicates do not construct another resource and that the original resource remains accessible.
• CI: Results for the current head are not available.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 3defa48e-380e-4d5d-9aab-3f4af118284e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

Walkthrough

The changes add tests for registrar creator exceptions, join receiver behavior and port metadata, and duplicate resource registration.

Changes: Registrar lifecycle

Layer / File(s)	Summary
Registrar creator exception handling test/core_misc_test.cpp	A test checks that a creator exception propagates, the creator is called once, and the error list is empty after destruction.

Join receiver routing

Layer / File(s)	Summary
Join routing and port validation test/multilayer_join_test.cpp	Tests cover receiver mappings, output readiness, selector order, invalid lookups, and index-port layer metadata across multilayer, same-layer, and fold joins.

Duplicate resource registration

Layer / File(s)	Summary
Duplicate registration behavior test/resources_test.cpp	Construction-counting fixtures verify that duplicate registrations throw without constructing another resource, while the original resource or limiter remains accessible.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: greenc-fnal, marcpaterno

Merge Risk: Minimal · previous review c6493

No behavior issue has been established that would prevent merging these tests.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly summarizes the added test coverage for registrar failures, resource registration, and joins.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
+ Coverage   90.36%   90.45%   +0.08%     
==========================================
  Files         177      177              
  Lines        5844     5844              
  Branches      923      923              
==========================================
+ Hits         5281     5286       +5     
+ Misses        363      360       -3     
+ Partials      200      198       -2     

Flag	Coverage Δ
amd64	90.45% <ø> (+0.08%)	⬆️
arm64	90.45% <ø> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e52668...a3fd174. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[knoepfel]

@CodeRabbit full review

[coderabbitai]

Action performed

Full review finished.

[coderabbitai]

Additional comments: 1

test/multilayer_join_test.cpp-147-152: 1

147-152: Trivial · Maintainability & Code Quality · Low value

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Move the using internal::receiver_for; declaration above the lambda, or confirm it is not needed.

The lambda at Lines 147-150 calls internal::receiver_for<3> with a qualified name. It does not depend on the using-declaration. Line 152 only serves the unqualified call at Line 169. That call passes the template argument <3>.

The code works as written. The ordering is still confusing, because the using-declaration sits between the lambda and its first use. Place it next to the other setup lines, or qualify the Line 169 call with internal::. A reader then does not have to track which calls use ADL or the using-declaration.

I did not check how the unqualified receiver_for<1ull>(join, 2u) call at Line 183 resolves for fold_join_node. It may rely on a using-declaration earlier in the file, in the unchanged lines I could not see. Please confirm that this resolves to the intended overload.

Review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 3b3759dc-8e15-4265-b053-546819e05353

Commits

Reviewing files that changed from the base of the PR and between 9e52668 and c649360.

Files selected for processing: 3

• test/core_misc_test.cpp
• test/multilayer_join_test.cpp
• test/resources_test.cpp

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Review details

Additional context used

Code guidelines: 1

AGENTS.md — auto-discovered

Path-based instructions: 1

Source excerpt: **Authoritative sources**: `.clang-format` and `.clang-tidy` are the ground truth for formatting and naming.

CodeRabbit inference engine (AGENTS.md)

Files:

• test/core_misc_test.cpp
• test/multilayer_join_test.cpp
• test/resources_test.cpp

Additional comments: 5

test/core_misc_test.cpp: 1

2-2: LGTM!

Also applies to: 11-11, 100-118

test/resources_test.cpp: 1

47-55: LGTM!

Also applies to: 289-293, 296-297, 302-306, 309-310

test/multilayer_join_test.cpp: 3

84-84: LGTM!

---

98-101: LGTM!

---

172-198: LGTM!