Skip to content

allow maximum zip document uploads to be configurable - #14735

Merged
giohappy merged 2 commits into
GeoNode:masterfrom
mvanhorn:fix/14700-configurable-zip-document-upload-limit
Oct 29, 2026
Merged

giohappy merged 2 commits into
GeoNode:masterfrom
mvanhorn:fix/14700-configurable-zip-document-upload-limit

Conversation

@mvanhorn

Copy link
Copy Markdown
Contributor

ZIP document uploads larger than 2 GiB are rejected as invalid or unsafe, preventing users from uploading legitimately large archives. The ZIP validator used a fixed 2 GiB cumulative uncompressed-size limit, with no deployment-level configuration. Any archive exceeding that hard-coded threshold was rejected.

The maximum cumulative uncompressed ZIP size can now be set with the ZIP_MAX_TOTAL_UNCOMPRESSED environment variable. Invalid, missing, or non-positive values fall back to the existing 2 GiB default. Tests cover the default, configured, invalid, and archive-validation behavior.

Ran make test locally on macOS for the geonode change; it fails the same way on the base branch, so the failure predates this change (it fails the same way on upstream/master).
The targeted test suite could not be collected because Django is unavailable in the environment.
The project test command could not start because the required .env file is missing.
The modified files pass the Black formatting check.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes Allow maximum zip document uploads to be configurable #14700] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

Fixes #14700

The maximum cumulative uncompressed ZIP size can now be set with the
`ZIP_MAX_TOTAL_UNCOMPRESSED` environment variable. Invalid, missing, or
non-positive values fall back to the existing 2 GiB default. Tests cover
the default, configured, invalid, and archive-validation behavior.

Fixes GeoNode#14700
@cla-bot

cla-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mvanhorn on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@giohappy

Copy link
Copy Markdown
Contributor

@mvanhorn please add your github account (username) to the .clabot file and push it inside this PR

@cla-bot

cla-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mvanhorn on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@giohappy
giohappy merged commit 282e632 into GeoNode:master Oct 29, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow maximum zip document uploads to be configurable

2 participants