Repository navigation
Conversation
The maximum cumulative uncompressed ZIP size can now be set with the `ZIP_MAX_TOTAL_UNCOMPRESSED` environment variable. Invalid, missing, or non-positive values fall back to the existing 2 GiB default. Tests cover the default, configured, invalid, and archive-validation behavior. Fixes GeoNode#14700
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mvanhorn on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
Contributor
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mvanhorn on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
giohappy
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZIP document uploads larger than 2 GiB are rejected as invalid or unsafe, preventing users from uploading legitimately large archives. The ZIP validator used a fixed 2 GiB cumulative uncompressed-size limit, with no deployment-level configuration. Any archive exceeding that hard-coded threshold was rejected.
The maximum cumulative uncompressed ZIP size can now be set with the
ZIP_MAX_TOTAL_UNCOMPRESSEDenvironment variable. Invalid, missing, or non-positive values fall back to the existing 2 GiB default. Tests cover the default, configured, invalid, and archive-validation behavior.Ran
make testlocally on macOS for the geonode change; it fails the same way on the base branch, so the failure predates this change (it fails the same way on upstream/master).The targeted test suite could not be collected because Django is unavailable in the environment.
The project test command could not start because the required
.envfile is missing.The modified files pass the Black formatting check.
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.
Fixes #14700