Skip to content

Run: Move in the System Packages sample app #1436

Closed

Description

@grayside

Current Staged Location: https://github.com/GoogleCloudPlatform/cloud-run-samples/tree/master/nodejs/system_package

This sample needs to be moved to nodejs-docs-samples so the tutorial can be updated to point to GitHub.

A core premise of the tutorial is its dependency on the graphviz system package. The tests will not pass without the presence of this package.

  • Option 1: Run the tests inside the container by first adding the docker client to the kokoro node:10-user container. (My preference)
  • Option 2: Add graphviz package to node:10-user container and (if needed) modify the sample to look up the binary from a different location.

@fhinkel please provide feedback on your preference.

Activity

  1. fhinkel commented on Jul 30, 2019

    @fhinkel
    Contributor

    Either way is fine assuming one doesn't make the image a lot bigger than the other, but I don't think so.

  2. removed their assignment
    on Sep 1, 2019
  3. fhinkel commented on Sep 1, 2019

    @fhinkel
    Contributor

    Let me know how you want to move forward with this. Thanks!

  4. grayside commented on Sep 4, 2019

    @grayside
    CollaboratorAuthor

    For alignment with how golang-samples will work, I'll add graphviz to the container.

  5. fhinkel commented on Sep 7, 2019

    @fhinkel
    Contributor

    Sounds good. Closing this as resolved. Feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions