functions/composer-storage-trigger/index.js sends nonexistent argument "iap.jwt" to "makeIapPostRequest" #1602

Activity

1. yoshi-automation

   added

   triage meI really want to be triaged.I really want to be triaged.

   on Feb 10, 2020
2. fhinkel

   added

   api: serverless

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

   and removed

   triage meI really want to be triaged.I really want to be triaged.

   on Feb 11, 2020
3. fhinkel commented on Feb 11, 2020

   

   fhinkel

   on Feb 11, 2020

   Contributor

   More actions

   @ace-n , could you have a look at this functions sample? Thanks
4. ace-n commented on Feb 12, 2020

   

   ace-n

   on Feb 12, 2020

   Last edited by ace-n

   Contributor

   More actions

   @leahecole owns this sample (per CODEOWNERS) - over to you 🙂
5. ace-n

   assigned

   leahecole

   on Feb 12, 2020
6. fhinkel

   added

   api: storageIssues related to the Cloud Storage API.Issues related to the Cloud Storage API.

   priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.

   and removed

   api: serverless

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   on Mar 24, 2020
7. yoshi-automation

   added

   🚨This issue needs some love.This issue needs some love.

   on Mar 30, 2020
8. meredithslota

   added

   api: composerIssues related to the Managed Service for Apache Airflow API.Issues related to the Managed Service for Apache Airflow API.

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   and removed

   🚨This issue needs some love.This issue needs some love.

   priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.

   on Apr 22, 2020
9. meredithslota commented on Apr 22, 2020

   

   meredithslota

   on Apr 22, 2020

   Contributor

   More actions

   I'm not sure if this makes sense but I'm adding the "composer" label so this is surfaced to our team, and dropping priority to P2.
10. meredithslota

    removed

    api: storageIssues related to the Cloud Storage API.Issues related to the Cloud Storage API.

    on Apr 22, 2020
11. leahecole commented on Jun 29, 2020

    

    leahecole

    on Jun 29, 2020

    Contributor

    More actions

    I'm investigating this now. I tried running the code in the relevant tutorial as is, and it seems to work - the DAG triggers and prints the appropriate info.

    I retried adding in the jwt parameter like it was before, and the DAG triggered then too, printing the appropriate info. This occurred because the makeIapPostRequest function never reads this value. The fact that the function never reads the value is likely why it was removed in this PR that was running eslint - it removed unused parameters. The line that you highlighted managed to get leftover somehow, but has since been updated. There are now no longer any references to this unused jwt - the ones that remain are used in the service account signature request.

    Thank you for opening this - I'm going to close it because as far as I can tell, the code doesn't need any updates at this time.
12. leahecole

    closed this as completedon Jun 29, 2020