Fix for MySQL Pooling Async Bug #1710

Activity

1. Antzy commented on Apr 9, 2020

   

   Antzy

   on Apr 9, 2020

   Last edited by Antzy

   Author

   More actions

   Might not be the optimum way but thus is how I solved it:

   var createPoolPromise = createPool();
   // [END cloud_sql_mysql_mysql_create]
   
   const ensureSchema = async () => {
     await createPoolPromise;
     // Wait for tables to be created (if they don't already exist).
     await pool.query(
       `CREATE TABLE IF NOT EXISTS votes
         ( vote_id SERIAL NOT NULL, time_cast timestamp NOT NULL,
         candidate CHAR(6) NOT NULL, PRIMARY KEY (vote_id) );`
     );
   };
   ensureSchema();
   

   I saved the returned Promise from createPool() and added await for it before every query. Not the prettiest solution but is there any better way?
2. fhinkel commented on Apr 9, 2020

   

   fhinkel

   on Apr 9, 2020

   Contributor

   More actions

   @Antzy 👋 Thanks for raising the issue. We'll fix it!
3. fhinkel

   assigned

   kurtisvg

   on Apr 9, 2020
4. fhinkel

   added

   type: docsImprovement to the documentation for an API.Improvement to the documentation for an API.

   api: cloudsqlIssues related to the Cloud SQL for MySQL API.Issues related to the Cloud SQL for MySQL API.

   on Apr 9, 2020
5. kurtisvg

   assigned

   shubha-rajan

   on Apr 9, 2020
6. shubha-rajan commented on Apr 9, 2020

   

   shubha-rajan

   on Apr 9, 2020

   Contributor

   More actions

   Thanks for raising the issue! I think using a middleware function to ensure pool creation might be a cleaner approach. The problem I see is that even if we await the promise to create the pool before each query, if table creation hasn't completed before those other queries, the other queries will fail. I think we should actually be awaiting the promise from ensureSchema before other queries. I opened #1712 with a possible fix

   👍React with 👍1Reacted by F. Hinkelmann
7. Antzy commented on Apr 12, 2020

   

   Antzy

   on Apr 12, 2020

   Author

   More actions

   Thanks for looking into this. My schema is pretty much guaranteed to be already in place, so I was await-ing pool creation before every query. But you are right, much better to await ensureSchema instead.
8. fhinkel

   closed this as completedin #1712on Apr 20, 2020