googlesapis 49 causes failing tests in storage transfer #1747

Activity

1. fhinkel

   added

   priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.

   type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

   api: storagetransferIssues related to the Storage Transfer Service API.Issues related to the Storage Transfer Service API.

   on Apr 27, 2020
2. fhinkel

   assigned

   meredithslota

   on Apr 27, 2020
3. meredithslota commented on Apr 28, 2020

   

   meredithslota

   on Apr 28, 2020

   Contributor

   More actions

   I feel like this is actually @laylasells's domain.
4. meredithslota

   assigned

   laylasells

   and unassigned

   meredithslota

   on Apr 28, 2020
5. yoshi-automation

   added

   🚨This issue needs some love.This issue needs some love.

   and removed

   🚨This issue needs some love.This issue needs some love.

   on May 3, 2020
6. fhinkel

   added

   api: storageIssues related to the Cloud Storage API.Issues related to the Cloud Storage API.

   on May 7, 2020
7. fhinkel commented on May 18, 2020

   

   fhinkel

   on May 18, 2020

   Last edited by fhinkel

   ContributorAuthor

   More actions

   @laylasells Could somebody look into this please? We're now 3 releases behind because we can't update any sample in the repo. Thanks!
8. frankyn

   assigned

   frankyn

   and unassigned

   laylasells

   on May 18, 2020
9. frankyn commented on May 18, 2020

   

   frankyn

   on May 18, 2020

   Contributor

   More actions

   Hi @fhinkel, I'm taking a look. Apologies for the delay.
10. frankyn commented on May 18, 2020

    

    frankyn

    on May 18, 2020

    Contributor

    More actions

    The example is inconsistent with how auth is currently documented at https://cloud.google.com/storage-transfer/docs/reference/rest/v1/transferJobs/list. I saw consistent failures of unauthorized failures.

    Then I found: https://github.com/googleapis/google-auth-library-nodejs/blob/41b0cb7b3dbae1b264b7de1cae82648c402d5cc3/CHANGELOG.md#v200

    I was able to fix the broken tests locally after updating the auth initialization in #1807. I want to make sure CI passes, but this might be the issue given auth is at 5.0.0 IIUC.
11. gcf-merge-on-green

    closed this as completedin #1812on May 19, 2020
12. gcf-merge-on-green

    added a commit that references this issue on May 19, 2020

    storagetransfer: update to use latest auth.getClient (#1812)

    ...

    This issue will close once commit aef5e8d is merged into the 'main' branch.

    aef5e8d