Skip to content

Update index.js for node.js 8+ - #1273

Closed
nbards wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
nbards:patch-1
Closed

nbards wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
nbards:patch-1

Conversation

@nbards

@nbards nbards commented May 9, 2019

Copy link
Copy Markdown

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 9, 2019
@fhinkel

fhinkel commented May 11, 2019

Copy link
Copy Markdown
Contributor

@ace-n Could you have a look. Thanks

@ace-n

ace-n commented May 13, 2019

Copy link
Copy Markdown
Contributor

@nbards can you do the following?

  1. Sign the CLA
  2. Update the comments above the method (to match the new parameters)

Once those are done, I can review this in more detail. Thanks!

@sdenef-adeo

Copy link
Copy Markdown

Maybe you can close this PR as it is resolved by #1335

@ace-n

ace-n commented Jul 26, 2019

Copy link
Copy Markdown
Contributor

Thanks for the ping @sdenef-adeo - will close this as it's obsolete.

@ace-n ace-n closed this Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no This human has *not* signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants