Incompatible with Cleanroom, causing crashes on startup. #11

Activity

1. ExDragine

   added

   bugSomething isn't workingSomething isn't working

   on Sep 25, 2024
2. Delfite commented on Apr 22, 2025

   

   Delfite

   on Apr 22, 2025

   Last edited by Delfite

   More actions

   I don't know how to code, but I do know how to google stuff. I believe the code causing the crash seen in the second log file is this code found in src\main\java\advancedshader\core\Core.java:

   public class Core implements ITweaker {
   
       public static final File source;
   
       static {
           File file = null;
           try {
               URL url = Core.class.getProtectionDomain().getCodeSource().getLocation();
               URI uri = url.toURI();
   
               file = new File(uri);
           } catch (URISyntaxException e) {}
   
           source = file;
       }
   }
   

   Apparently, performing a URI here is bad because the file it's trying to read is inside another JAR file, and URIs are only meant to be performed on JAR files themselves or a different type of file, not whatever is contained within the file because the operating system only sees JAR files as a single file, not a folder that contains files.

   Someone on stack overflow recommended using getResourceAsStream(...); instead of whatever this code is trying to do. ChatGPT said something similar and spat out this code:

   import java.io.BufferedReader;
   import java.io.InputStream;
   import java.io.InputStreamReader;
   import java.nio.charset.StandardCharsets;
   
   public class Core implements ITweaker {
   
       public static final String sourceContent;
   
       static {
           String content = null;
           try (
               InputStream stream = Core.class.getResourceAsStream("/your_resource.txt");
               BufferedReader reader = new BufferedReader(new InputStreamReader(stream, StandardCharsets.UTF_8))
           ) {
               if (stream != null) {
                   StringBuilder sb = new StringBuilder();
                   String line;
                   while ((line = reader.readLine()) != null) {
                       sb.append(line).append(System.lineSeparator());
                   }
                   content = sb.toString();
               } else {
                   System.err.println("Resource not found!");
               }
           } catch (Exception e) {
               e.printStackTrace();
           }
   
           sourceContent = content;
       }
   }
   

   Hopefully this helps someone fix this guy's issue because I'm nowhere near qualified for software development.

   👍React with 👍2Reacted by Ashen.Elaina and Small__Mushroom
3. floosher commented on Sep 11, 2026

   

   floosher

   on Sep 11, 2026

   More actions

   my fork https://github.com/floosher/AdvancedShader works with cleanroom. It is vibecoded so use it at your own risk!