Skip to content

fix(protocol): add missing ConfigSource values - #3842

Open
sebxt wants to merge 1 commit into
IBM:mainfrom
sebxt:fix/config-source-missing-values
Open

sebxt wants to merge 1 commit into
IBM:mainfrom
sebxt:fix/config-source-missing-values

Conversation

@sebxt

@sebxt sebxt commented Oct 18, 2026

Copy link
Copy Markdown

Brokers report broker logger config entries with DYNAMIC_BROKER_LOGGER_CONFIG (6), and newer brokers use CLIENT_METRICS_CONFIG (7) and GROUP_CONFIG (8) for client metrics and group configs. ConfigSource stopped at SourceDefault (5), so describing a BrokerLoggerResource returned entries whose source printed as Source Invalid: 6 and could not be compared against a named constant.

This adds SourceDynamicBrokerLogger, SourceClientMetrics and SourceGroup with the ids used by the Java client's DescribeConfigsResponse.ConfigSource, and the matching String() cases. Wire encoding is unchanged; the decoder already stored the raw value.

TestDescribeConfigsResponseBrokerLoggerv1 decodes a v1 response for a broker logger resource with source 6 and checks the source name. TestConfigSourceString covers every source id. Both fail on main and pass with this change. go test ./... passes.

Fixes #3841

Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConfigSource has no values for sources 6, 7 and 8, so broker logger configs report "Source Invalid: 6"

1 participant