Repository navigation
Conversation
Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brokers report broker logger config entries with
DYNAMIC_BROKER_LOGGER_CONFIG(6), and newer brokers useCLIENT_METRICS_CONFIG(7) andGROUP_CONFIG(8) for client metrics and group configs.ConfigSourcestopped atSourceDefault(5), so describing aBrokerLoggerResourcereturned entries whose source printed asSource Invalid: 6and could not be compared against a named constant.This adds
SourceDynamicBrokerLogger,SourceClientMetricsandSourceGroupwith the ids used by the Java client'sDescribeConfigsResponse.ConfigSource, and the matchingString()cases. Wire encoding is unchanged; the decoder already stored the raw value.TestDescribeConfigsResponseBrokerLoggerv1decodes a v1 response for a broker logger resource with source 6 and checks the source name.TestConfigSourceStringcovers every source id. Both fail on main and pass with this change.go test ./...passes.Fixes #3841