Skip to content

make pack recipe compatible with py2 & py3 - #3

Closed
freddrake wants to merge 1 commit into
Infinidat:developfrom
keepertech:fd-py2-py3
Closed

freddrake wants to merge 1 commit into
Infinidat:developfrom
keepertech:fd-py2-py3

Conversation

@freddrake

Copy link
Copy Markdown
Contributor

No description provided.

@wiggin15

Copy link
Copy Markdown
Contributor

Thanks for the PR!
We do still want to support Python 2.7 (for the little time it has left), but support for Python <2.7 is not needed. Since the "filter" parameter exists in Python 2.7, I think we don't really need to check whether the Python version is 2 or 3, and use "exclude"/"filter" according to this check, but rather we can just switch to use the newer "filter" parameter and change the filter method accordingly.

@freddrake

Copy link
Copy Markdown
Contributor Author

That makes sense to me! No need for this PR them; the original patch @Edward-Knight sent via Infinidat/relocatable-python3#8 should probably be applied instead.

@freddrake freddrake closed this Sep 17, 2019
@freddrake

Copy link
Copy Markdown
Contributor Author

I see @Edward-Knight also provided his patch in issue #2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants