Skip to content

BUG: Fix oneMKL and cuFFTW builds, scope FindFFTW for projects using ITK - #7020

Open
hjmjohnson wants to merge 12 commits into
InsightSoftwareConsortium:mainfrom
hjmjohnson:onemkl-fftw-fixes
Open

hjmjohnson wants to merge 12 commits into
InsightSoftwareConsortium:mainfrom
hjmjohnson:onemkl-fftw-fixes

Conversation

@hjmjohnson

@hjmjohnson hjmjohnson commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Follow-ups to #6999, tracked in #7027: oneMKL found through its MKLConfig.cmake (MKL::MKL, per @blowekamp), cuFFTW and oneMKL builds that compile and run, cuFFTW and oneMKL settings passed to projects that find ITK without leaking FindFFTW variables, an optimized bundled FFTW in Debug builds, and a GoogleTest for the ITKFFTW module.

Commits (twelve, on main)
Commit Fixes
BUG: Find oneMKL 2024+ layout and export MKLROOT to FFTW consumers oneMKL 2024+ lib/ layout; consumers losing a custom MKLROOT (greptile P1 on #6999); system fftw3.h shadowing oneMKL's. The library search and MKLROOT export are replaced by the MKLConfig.cmake commit below; the ia32 error and renames remain
BUG: Build bundled FFTW with release optimization in all configurations a Debug ITK compiled FFTW with -g and no optimization; only optimization flags are replaced, so -g and sanitizer flags are kept (greptile P2)
BUG: Add each module to ITKTargets_MODULES only once most modules listed twice
ENH: Add a GoogleTest for the ITKFFTW module the module had no test of its own
BUG: Export cuFFTW library paths to FFTW consumers consumers losing custom cuFFTW paths (greptile P1 on #6999)
ENH: Keep FindFFTW variables out of projects that find ITK FFTW_FOUND, FFTW_INCLUDE, FFTW{D,F}_LIBRARIES set in the consumer's scope; adds a migration guide entry
ENH: Find oneMKL through its MKLConfig.cmake package replaces the hand-written oneMKL library list, link group, and include search with MKL::MKL (oneMKL 2021.3+), static, sequential, LP64 by default; finds fftw3.h from the target's include directories; passes MKL_DIR and the link settings to consumers as overridable defaults, not cache entries; migration guide and build docs updated
BUG: Include cufftw.h in FFTW filter headers under ITK_USE_CUFFTW the direct fftw3.h includes (since 5.4.7) failed every cuFFTW build; CUDA ships only cufftw.h
BUG: Use PocketFFT in the curvature regularizer under ITK_USE_CUFFTW its DCT needs FFTW real-to-real transforms, which cuFFTW lacks
BUG: Exclude FFTW r2r plan helpers from ITK_USE_CUFFTW builds fftw_plan_r2r and fftwf_plan_r2r do not exist in cuFFTW
BUG: Find cuFFTW from the CUDA Toolkit without explicit paths Windows CUDA keeps libraries in lib/x64; FindCUDAToolkit (CUDAToolkit_ROOT, CUDA_PATH, nvcc) now supplies hints
BUG: Avoid FFTW r2r plans under ITK_USE_MKL oneMKL's fftw_plan_r2r returns a null plan, so the curvature registration tests aborted; defines ITK_USE_MKL in itkConfigure.h, uses PocketFFT in the curvature regularizer, and leaves out CurvatureRegistrationFilter and its two examples, as under cuFFTW (@dzenanz)
Testing at the current head

Linux x86_64 (GCC 13, CMake 3.28), minimal ITK with Module_ITKFFT, Module_ITKFFTW, Module_VariationalRegistration, and Module_ITKPDEDeformableRegistration:

Case Result
oneMKL 2025.3.1, dynamic, LP64 default 46/46 FFT, FFTW, and curvature tests, including the FFTWModule GoogleTest (now run under oneMKL) and VariationalRegistrationCurvature2D/3DTest
Same, curvature regularizer without the ITK_USE_MKL guard both curvature tests abort with PLAN_CREATION_FAILED after "Starting registration..."
Bundled FFTW, Debug 46/46; all 1,260 FFTW sources compiled with -O3 -g
Bundled FFTW, Ninja Multi-Config with a custom Coverage configuration (configure only) FFTW gets -O3 in every configuration; --coverage -g kept
Project that runs find_package(MKL) in one directory and ITK's FindFFTW in a sibling configures and generates; FFTW::Double uses oneMKL's include/fftw (before: generate failed on /include/fftw)

KWStyle was not built, so ITKFFTKWStyleTest did not run. Windows MSVC with oneMKL at this head is not yet re-run.

oneMKL details (first commit; items 2 and 3 are superseded by the MKLConfig.cmake commit)
  1. oneMKL 2024+ installs libraries in MKLROOT/lib; FindFFTW searched only lib/intel64 and failed with libmkl_intel_ilp64.a not found. Defaults pointed at the retired compilers_and_libraries paths.
  2. With ITK_USE_SYSTEM_FFTW, the exported ITKFFTW module re-runs FindFFTW downstream but did not carry MKLROOT, so consumers fell back to the hard-coded default. ITK's MKLROOT now seeds the app's cache, the same way ENH: Build FFTW as an ITKFFTW third-party module with FetchContent #6999 seeds the FFTW library paths, unless the app sets MKLROOT.
  3. find_path() searches system directories before MKLROOT, so a system FFTW fftw3.h (/usr/include, from libfftw3-dev) was compiled against oneMKL's libraries. On reconfigure, MKLROOT was then derived from that path as /, and / was exported to consumers. Items 1 and 3 also affect main before ENH: Build FFTW as an ITKFFTW third-party module with FetchContent #6999.
  4. The 32-bit branch checked a misspelled WIN variable; oneMKL is 64-bit only, so it is now an error.
Why the FindFFTW variables are kept local rather than renamed

With a system FFTW the exported code runs FindFFTW in the scope of the app's find_package(ITK) (module loading uses macros), so every result variable reached the app. No ITK code reads them, and a search of 300 downstream repositories (the 47 projects in the downstream build forest, including RTK, plus 253 Slicer extensions) found no user. Renaming to FFTW_INCLUDE_DIRS/FFTW_LIBRARIES would collide with apps' own finders: Plastimatch sets FFTW_LIBRARIES before find_package(ITK). The search now runs inside a function, so only the FFTW::Double/FFTW::Float imported targets reach the app; the input hints (FFTW_INCLUDE_PATH, FFTW{D,F}_BASE_LIB, ...) are unchanged. Discussion: #6999 (comment).

Testing (at `b671b51`, before the patch-identical rebase onto main)

macOS arm64 (Apple clang, CMake 3.26), minimal ITK with Module_ITKFFT:

Case Result
Bundled, shared Release 91/91 FFT tests; 93/93 with Module_ITKFFTW=ON (new FFTWModule tests pass, double and float); install has only libitkfftw3* and fftw3.h; 6 consumers run
Bundled, static Debug 91/91; FFTW compiled with -O3 (no -g); 4 consumers run
Homebrew system FFTW 91/91; new GoogleTest 2/2; consumers including one with its own FindFFTW.cmake run
Variable check, system FFTW consumer that sets FFTW_LIBRARIES before find_package(ITK): before this PR 6 FindFFTW variables leak; now none leak, its value is kept, FFTW::Double exists, and it builds and runs
cuFFTW paths (fake cuFFTW outside default paths, configure only) before: consumer fails Could NOT find FFTW; now: consumer finds FFTW::Float from the exported paths
No precision selected configure fails with the expected message

Linux x86_64 (GCC 13.3, CMake 4.2):

Case Result
oneMKL 2026.1, static 91/91; consumers with no MKLROOT, an override, CMP0126 OLD, and the variable check all run
System FFTW (libfftw3-dev), renamed libraries, no threads library 91/91; consumers run; renamed library paths reused downstream
Bundled shared Release, static Debug 91/91; Debug FFTW compiled with -O3; consumers run

Shared install-tree consumers on Linux need LD_LIBRARY_PATH because ITK sets no install RPATH (same on main, tracked in #7027).

Windows: @dzenanz tested the oneMKL commit with MSVC 2022 (92/92, MKLROOT from the environment as a backslash path) in #6999 (comment). The release-flags commit has not been re-run on Windows Debug yet.

Testing of the last two changes (head 8441147)

MKLConfig.cmake path, Linux x86_64 (GCC 13.3, CMake 4.2, oneMKL 2026.1, static, minimal ITK with Module_ITKFFT):

Case Result
-DMKLROOT MKL_DIR found; 0 warnings; 91/91 FFT tests; install exports MKL_DIR unless the app sets MKLROOT
Consumers of that install (no MKLROOT, MKLROOT override, CMP0126 OLD, variable check) all configure, build, and run
MKLROOT only in the environment 91/91
MKL_DIR only 91/91
System FFTW, no MKL 91/91
ITK with MKL_LINK=dynamic 91/91; consumers inherit dynamic (3 libmkl shared libraries), -DMKL_LINK=static in the app overrides it, an app setting MKLROOT still gets dynamic

Bundled FFTW flags, macOS arm64, Debug: with CMAKE_C_FLAGS_DEBUG set to -g -fsanitize=address, then -g -fno-omit-frame-pointer, FFTW objects keep those flags plus -O3, with no -O0; FFT tests 94/94. (The sanitizer run itself deadlocks inside the pixi clang ASan runtime at startup on this macOS, before any ITK code runs, so the second flag was used to run the tests.) Linux GCC 13.3, Debug with -g -fno-omit-frame-pointer -I"/tmp/dbg hdrs": the quoted path reaches FFTW intact, with -O3 and no -O0; 93/93. MSVC flag removal (/Od /RTC1 /Zi /Ob0 -> /Zi) checked only with a cmake -P script.

Windows testing of the cuFFTW commits

Windows 11, MSVC 14.51 (VS 2026), Ninja, stock CUDA 13.4, NVIDIA T1000, minimal ITK with Module_ITKFFT and Module_VariationalRegistration, ITK_USE_CUFFTW=ON:

Case Before After
Configure, no CUFFTW_* hints CUFFTW_INCLUDE_PATH, CUFFTW_LIB, CUFFT_LIB not found all three found from CUDA_PATH (include, lib/x64)
Configure with explicit hints, build fails: fftw3.h not found, then fftwf_plan_r2r undeclared builds; ITKFFTTestDriver links cufftw64_12.dll
ctest -R "FFT|VariationalRegistration" not run 116/116, including all 24 VariationalRegistration tests (curvature regularizer on PocketFFT, elastic on cuFFTW)

Results for the full Windows matrix at this head are in a comment below.

AI assistance
  • Tool: Claude Code (claude-opus-5-5)
  • Contribution: reproduced the failures, wrote the changes, answered review findings, and ran the tests above on macOS, Linux, and Windows hosts

@github-actions github-actions Bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Filtering Issues affecting the Filtering module area:ThirdParty Issues affecting the ThirdParty module area:Documentation Issues affecting the Documentation module labels Oct 27, 2026
@hjmjohnson

Copy link
Copy Markdown
Member Author

Rebased onto #6999's new head b5c5da0. The oneMKL commit conflicted with #6999's rewritten export block, so this force-push combines the rebase with a merge of that block. MKLROOT now seeds the app's cache, the same way #6999 seeds the FFTW library paths, rather than being set as a normal variable and unset afterward. The rest of the commit is unchanged. Retest results are in the PR description.

@blowekamp

Copy link
Copy Markdown
Member

Would it be easier to just drop MKL specialization in FindFFTW? Can we drop support for the older CMake configuration variables, and just use MKL's exported targets from its package?

Moving to the modern CMake targets has simplified much of the code by dropping the redeious and frequently incorrect management of these variables.

https://www.intel.com/content/www/us/en/docs/onemkl/developer-guide-macos/2023-0/cmake-config-for-onemkl.html

P.S. Perhaps the variables could be dropped with FFTW too?

@hjmjohnson hjmjohnson changed the title BUG: Find oneMKL 2024+ layout and export MKLROOT to FFTW consumers BUG: FFTW follow-ups to #6999: oneMKL, cuFFTW and MKLROOT export, scoped FindFFTW, tests Oct 28, 2026
@github-actions github-actions Bot removed the area:Filtering Issues affecting the Filtering module label Oct 29, 2026
@hjmjohnson
hjmjohnson marked this pull request as ready for review October 29, 2026 15:29
@hjmjohnson

hjmjohnson commented Oct 29, 2026 •

Copy link
Copy Markdown
Member Author

@blowekamp Good idea. It is now in this PR as the last commit, ENH: Find oneMKL through its MKLConfig.cmake package (MKL::MKL, oneMKL 2021.3+), tracked in #7027. FFTW itself has no usable CMake targets to switch to (Homebrew's config defines none, Ubuntu ships only pkg-config), so FindFFTW stays for FFTW.

@hjmjohnson
hjmjohnson marked this pull request as draft October 29, 2026 15:34
@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge; no new actionable defect was established.

Summary

This PR repairs oneMKL and cuFFTW builds and keeps FFTW finder results out of applications that find ITK.

  • ITK can build FFT filters with oneMKL or cuFFTW.
  • Projects that use ITK keep their FFT choices without inheriting finder variables.
  • Curvature registration uses transforms that oneMKL and cuFFTW support.
  • Bundled FFTW stays optimized in Debug and gains module-level transform tests.
  • The exported module list keeps each module name once.

The earlier review fixes remain in place. Review checks were based on source inspection; no builds or tests were run.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[ITK FFTW configuration] --> B{Selected library}
  B -->|oneMKL| C[Find MKL::MKL]
  B -->|cuFFTW| D[Find CUDA headers and libraries]
  B -->|System FFTW| E[Find selected precisions]
  B -->|Bundled FFTW| F[Build optimized libraries]
  C --> G[Export dependency hints]
  D --> G
  E --> G
  G --> H[Application finds dependencies inside a function]
  H --> I[FFTW targets remain available]
  H --> J[Finder result variables stay local]
Loading

Reviews (7) · Last reviewed commit: "BUG: Avoid FFTW r2r plans under ITK_USE_..." · Reviewed by Greptile

@hjmjohnson
hjmjohnson force-pushed the onemkl-fftw-fixes branch 3 times, most recently from aa4c748 to 92f8755 Compare October 29, 2026 16:15
@hjmjohnson hjmjohnson changed the title BUG: FFTW follow-ups to #6999: oneMKL, cuFFTW and MKLROOT export, scoped FindFFTW, tests BUG: FFTW follow-ups to #6999: oneMKL via MKLConfig, cuFFTW export, scoped FindFFTW, tests Oct 29, 2026
@hjmjohnson

Copy link
Copy Markdown
Member Author

Force-push 6de1618..dd17871 is a plain rebase on main; dd17871..92f8755 is content only: the MKLConfig commit plus the greptile P2 fix folded into the release-flags commit.

@hjmjohnson

Copy link
Copy Markdown
Member Author

@greptileai review this draft before I make it official

Comment thread Modules/ThirdParty/FFTW/CMakeLists.txt Resolved
@hjmjohnson

Copy link
Copy Markdown
Member Author

@greptileai review this draft before I make it official

@hjmjohnson
hjmjohnson marked this pull request as ready for review October 29, 2026 19:29
@dzenanz

dzenanz commented Oct 30, 2026

Copy link
Copy Markdown
Member

Windows retest of #7020 at 8441147cdbe (Windows 11, MSVC 14.44 / VS 2022, CMake 4.4, ITK_USE_FFTWD=ON ITK_USE_FFTWF=ON Module_ITKFFTW=ON, ctest -R FFT)

Configuration Result
Bundled FFTW, Ninja Release 94/94
Bundled FFTW, Visual Studio 17 2022, Debug 94/94
Bundled FFTW, Visual Studio 17 2022, Release 94/94
oneMKL 2026.1 (conda-forge mkl-devel/mkl-static) via MKL_DIR 92/92, links mkl_intel_ilp64/mkl_core/mkl_sequential
System FFTW (conda-forge fftw 3.3.11, no separate threads libs) 94/94
cuFFTW (CUDA 13.2) configure OK, build fails, see below

The 94 includes the two new FFTWModule.* GTests. In the multi-config build, the bundled FFTW gets /O2 in Debug while keeping the debug CRT. The system FFTW threads-library regression I reported earlier is fixed.

A downstream project that links only ITK::ITKFFTModule and calls the FFTW API directly builds and runs against the bundled (build and install trees), oneMKL (without MKLROOT), and system FFTW install trees. None of FFTW_INCLUDE, FFTWD_LIB, FFTW_FOUND or MKLROOT leaks into the consumer's scope.

cuFFTW does not build, but the cause is older than this PR. itkFFTWComplexToComplex1DFFTImageFilter.hxx and nine other FFT headers include fftw3.h unconditionally, and CUDA ships only cufftw.h. Base 2e353bf3975 has the same includes. The exported ITKFFTW.cmake does carry ITK_USE_CUFFTW, CUFFTW_INCLUDE_PATH, CUFFT_LIB and CUFFTW_LIB. FindFFTW does not find the libraries on Windows without hints, because CUDA puts them in lib/x64.

Not tested: Python wrapping, the ITKFFTW GTest without explicit Module_ITKFFTW=ON (with ITK_BUILD_DEFAULT_MODULES=OFF the module is enabled only as a dependency, so its tests are not built).

AI assistance

Builds, tests, and this summary were prepared with Claude Code and reviewed by me.

@github-actions github-actions Bot added the area:Core Issues affecting the Core module label Nov 15, 2026
@hjmjohnson hjmjohnson changed the title BUG: FFTW follow-ups to #6999: oneMKL via MKLConfig, cuFFTW export, scoped FindFFTW, tests BUG: Fix oneMKL and cuFFTW builds, scope FindFFTW for projects using ITK Nov 15, 2026
@hjmjohnson

Copy link
Copy Markdown
Member Author

Force-push e047fc3527→90a6cd7021 is review fixes only (same base), each folded into the commit that owns the code:

  • oneMKL's fftw3.h is found from MKL::MKL's include directories, so it works when MKL::MKL was created in another directory scope (MKL_ROOT is empty there).
  • MKL_INTERFACE defaults to lp64. oneMKL's FFTW3 wrappers are identical under LP64 and ILP64, and an ILP64 MKL::MKL is global, so it would silently become the interface for a project that later finds oneMKL for BLAS.
  • The oneMKL link settings reach projects that find ITK as overridable defaults, not cache entries.
  • The ITKFFTW GoogleTest now runs under oneMKL (it passes); bundled FFTW is optimized for custom build types too; the migration guide notes that CurvatureRegistrationFilter is unavailable with oneMKL or cuFFTW.

Tested on Linux with oneMKL 2025.3.1 and with bundled FFTW (Debug); results are in the description.

@hjmjohnson

Copy link
Copy Markdown
Member Author

Force-push 90a6cd7021→f9be9bce77 is review nits only (same base): bundled FFTW is also optimized for custom configurations under multi-config generators (checked with Ninja Multi-Config: a Coverage configuration gets -O3 with --coverage -g kept), a doc line is rewrapped, and the release-optimization commit message no longer calls the result "debuggable". Linux oneMKL and bundled Debug builds: 46/46 each.

@hjmjohnson

Copy link
Copy Markdown
Member Author

@greptileai review

Comment thread Modules/ThirdParty/FFTW/CMakeLists.txt Resolved
oneMKL 2024 and later install libraries in MKLROOT/lib, so the
lib/intel64-only search failed with "libmkl_intel_ilp64.a not found".
Search both directories, and default MKLROOT to the oneAPI install
paths instead of the retired compilers_and_libraries locations.

find_path() searched system directories before MKLROOT, so a system
FFTW fftw3.h (e.g. /usr/include from libfftw3-dev) was used with the
oneMKL libraries, and a reconfigure then derived MKLROOT as "/". Search
only MKLROOT/include/fftw, and drop a cached path outside it.

With ITK_USE_SYSTEM_FFTW, a downstream find_package(ITK) re-runs
FindFFTW, which lost a custom MKLROOT. Seed the app's cache with ITK's
MKLROOT, as is done for the FFTW library paths, unless the app sets
MKLROOT. Honor an existing MKLROOT variable and keep it set under
CMP0126 OLD.

oneMKL is 64-bit only, so the ia32 branch (with its misspelled WIN
check) becomes an error. Rename MKL to oneMKL in the option, comments,
and build docs.
The removed ExternalProject forced FFTW_BUILD_TYPE=Release. As an
add_subdirectory, FFTW inherited the ITK build type, so a Debug ITK
compiled FFTW with -g and no optimization, which makes every FFT in a
Debug build far slower. Replace only the optimization flags of each
non-Release configuration, so -g and sanitizer flags are kept.
The interface-library registration also ran for modules already added
when their src directory was processed, listing 93 of 133 modules
twice. Append only modules not yet in the list.
The ITKFFTW module had no test of its own. One GoogleTest driver now
checks each enabled precision through ITK::ITKFFTWModule: an impulse
must transform to a flat spectrum with a threaded plan. The test is
skipped for cuFFTW, which has no FFTW threading interface.
With ITK_USE_CUFFTW and ITK_USE_SYSTEM_FFTW, a downstream
find_package(ITK) re-runs FindFFTW but received none of the paths ITK
found, so a cuFFTW outside the default search paths was not found and
the app failed to configure.

Seed the app's cache with CUFFTW_INCLUDE_PATH, CUFFT_LIB, and
CUFFTW_LIB, as is done for the FFTW and oneMKL paths. Cache entries the
app already set are kept.
@hjmjohnson

Copy link
Copy Markdown
Member Author

@greptileai review

Comment thread Modules/ThirdParty/FFTW/CMakeLists.txt Resolved
hjmjohnson and others added 7 commits November 14, 2026 20:17
With a system FFTW, the exported ITKFFTW code runs FindFFTW in the
scope of the app's find_package(ITK), so FFTW_FOUND, FFTW_INCLUDE, and
FFTW{D,F}_LIBRARIES were set in the app and could overwrite its own
FFTW variables.

Run the search inside a function. Imported targets do not follow
function scope, so the FFTW::Double and FFTW::Float targets that
ITK::ITKFFTWModule links still reach the app, while FindFFTW's results
and the CMAKE_MODULE_PATH change stay local. No ITK code reads those
results, and none of 300 downstream repositories checked does either.
ITK_USE_MKL and ITK_USE_CUFFTW are still set before the function, so
projects that find ITK can test them.
FindFFTW listed oneMKL's static libraries, link flags, and include
paths by hand, which broke when oneMKL changed its layout. oneMKL
2021.3 and newer install MKLConfig.cmake, whose MKL::MKL target carries
the libraries and link group. Link it statically with sequential
threading and the LP64 interface; the FFTW3 interface is the same under
LP64 and ILP64, and LP64 matches what MKLConfig gives a project that
later finds oneMKL for BLAS. Pass MKL_DIR rather than MKLROOT to
projects that find ITK, and the link settings as defaults they can
override.
The CUDA Toolkit ships cufftw.h but no fftw3.h, so the direct
fftw3.h includes failed every ITK_USE_CUFFTW build.
The regularizer's DCT needs FFTW real-to-real transforms, which
cuFFTW does not implement.
cuFFTW does not implement fftw_plan_r2r or fftwf_plan_r2r.
On Windows the toolkit libraries are in lib/x64, outside the default
search paths. FindCUDAToolkit locates the toolkit from
CUDAToolkit_ROOT, CUDA_PATH or nvcc on PATH.
oneMKL's FFTW3 interface declares fftw_plan_r2r but returns a null
plan, so VariationalRegistrationCurvature2DTest and 3DTest crash right
after registration starts. Define ITK_USE_MKL in itkConfigure.h, use
PocketFFT in the curvature regularizer under it as under cuFFTW, and
exclude CurvatureRegistrationFilter and the examples that use it.
@hjmjohnson

Copy link
Copy Markdown
Member Author

Force-push 1fff976ab6→a1d34da3e9 changes only one commit message (same tree, same base): "Keep FindFFTW variables out" no longer lists ITK_USE_MKL/ITK_USE_CUFFTW among the variables kept local, and says they are still set for projects that find ITK.

@hjmjohnson

Copy link
Copy Markdown
Member Author

@greptileai review

@hjmjohnson

Copy link
Copy Markdown
Member Author

ITK.macOS.Python failed three minutes in, at "Download dashboard script", because the runner could not resolve hostnames ("nodename nor servname provided"). That is a runner network fault, not this PR; re-running it.

@hjmjohnson

Copy link
Copy Markdown
Member Author

/azp run ITK.macOS.Python

@hjmjohnson

Copy link
Copy Markdown
Member Author

Windows/MSVC check on a1d34da3e9 (VS 18, MSVC 14.51, CMake 4.4.5, Ninja): all tests pass in a oneMKL 2025.3.1 build (MKL_LINK=dynamic, Release, 303/303) and in a bundled-FFTW Ninja Multi-Config build (Debug and Release, 303/303 each).

Details
  • oneMKL links mkl_intel_lp64_dll, mkl_sequential_dll, and mkl_core_dll, so LP64 is the default; ITK_USE_MKL reaches itkConfigure.h, and neither FFTW_INCLUDE nor MKL_INTERFACE is left in the cache.
  • Bundled FFTW in the Debug configuration compiles with /O2 /Ob2 /DNDEBUG and keeps -MDd -Z7, while ITK's own sources stay at /Od /RTC1.
  • With dynamic oneMKL on Windows, the MKL bin directory must be on PATH at build time, because GoogleTest discovery runs the test drivers during the build.
  • Modules enabled: ITKGroup_Core, ITKFFT, ITKFFTW, ITKPDEDeformableRegistration, and VariationalRegistration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Core Issues affecting the Core module area:Documentation Issues affecting the Documentation module area:Examples Demonstration of the use of classes area:Filtering Issues affecting the Filtering module area:Registration Issues affecting the Registration module area:ThirdParty Issues affecting the ThirdParty module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants