Repository navigation
Fix placeholder numbering in UPDATE SET subqueries - #405
Open
skyon0522-ai wants to merge 1 commit into
Open
skyon0522-ai wants to merge 1 commit into
skyon0522-ai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a shared Dollar-formatted
StatementBuilderbuilds both an UPDATE and its SET subquery, the subquery replaces its placeholders before the outer UPDATE does. The inner and outer WHERE clauses can therefore both use$1, despite returning separate arguments.Use the existing
nestedToSqlhelper for SET values, as for other nested query parts, so the outer statement applies its placeholder format. Keep the existing SELECT parentheses and genericSqlizerfallback.Fixes #326.
Validation on Go 1.27.2 / Linux amd64:
go test -count=1 ./...andgo vet ./...pass.gofmt -l update.go update_test.goandgit diff --checkare clean.Validation covers generated SQL and arguments; no live database integration or other Go version was tested.
This change was prepared with AI assistance.