Skip to content

feat(Theming): add semantic colors - #4115

Open
corvinsz wants to merge 3 commits into
MaterialDesignInXAML:masterfrom
corvinsz:fix/4114
Open

corvinsz wants to merge 3 commits into
MaterialDesignInXAML:masterfrom
corvinsz:fix/4114

Conversation

@corvinsz

@corvinsz corvinsz commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

fixes #4114

Adds semantic, theme-aware colors as proposed in the issue.
The colors were generated using the MaterialDesignToolkit.ResourceGeneration project, so the implementation should be straightforward.

Screenshots

Buttons

Light Dark
image image

ColorTools

The brush MaterialDesign.Brush.ValidationError is not new, but I added it to the ColorTools page for completeness.

Light Dark
image image

@corvinsz
corvinsz marked this pull request as ready for review October 25, 2026 08:01
]
},
{
"name": "MaterialDesign.Brush.Error",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should make this an alias for this that is the validation error brush. I think this is a better name and perhaps the old brush name should slowly be phased out. Thoughts?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corvinsz Thanks for doing this!! I have found myself doing handling this "manually" in multiple MDIX apps. And I agree with @Keboo I think the new names are better, so I vote for phasing out the old one.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Keboo Do you mean making MaterialDesign.Brush.ValidationError & MaterialDesignValidationErrorBrush obsolete keys for the new MaterialDesign.Brush.Error? If so, I agree.

{
    "name": "MaterialDesign.Brush.Error",
    "themeValues": {
        "light": "#F44336",
        "dark": "#FF3F5F"
    },
    "alternateKeys": [],
    "obsoleteKeys": [
+        "MaterialDesign.Brush.ValidationError",
+        "MaterialDesignValidationErrorBrush"
    ]
}

Lmk if we are in agreement, then I will start working on it!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Semantic, Theme-Aware Colors

3 participants