Repository navigation
Conversation
corvinsz
marked this pull request as ready for review
October 25, 2026 08:01
Keboo
approved these changes
Oct 26, 2026
| ] | ||
| }, | ||
| { | ||
| "name": "MaterialDesign.Brush.Error", |
Member
There was a problem hiding this comment.
I wonder if we should make this an alias for this that is the validation error brush. I think this is a better name and perhaps the old brush name should slowly be phased out. Thoughts?
Contributor
Member
Author
There was a problem hiding this comment.
@Keboo Do you mean making MaterialDesign.Brush.ValidationError & MaterialDesignValidationErrorBrush obsolete keys for the new MaterialDesign.Brush.Error? If so, I agree.
{
"name": "MaterialDesign.Brush.Error",
"themeValues": {
"light": "#F44336",
"dark": "#FF3F5F"
},
"alternateKeys": [],
"obsoleteKeys": [
+ "MaterialDesign.Brush.ValidationError",
+ "MaterialDesignValidationErrorBrush"
]
}Lmk if we are in agreement, then I will start working on it!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4114
Adds semantic, theme-aware colors as proposed in the issue.
The colors were generated using the
MaterialDesignToolkit.ResourceGenerationproject, so the implementation should be straightforward.Screenshots
Buttons
ColorTools
The brush
MaterialDesign.Brush.ValidationErroris not new, but I added it to theColorToolspage for completeness.