Skip to content
This repository was archived by the owner on Sep 23, 2023. It is now read-only.
This repository was archived by the owner on Sep 23, 2023. It is now read-only.

wikicache.json can cache partially built wiki results #113

Closed

Description

@edg2s

If someone visits index.php while a wiki is building, the metadata for a partially built wiki may get cached. We could not cache broken wikis, but that would mean we try to evaluate metadata for actually broken wikis on every view.

Activity

  1. edg2s commented on Sep 17, 2020

    @edg2s
    CollaboratorAuthor

    It's also not great the cache is fully cleared whenever a new wiki is detected. It would be better if we only every wrote to the cache when wikis were created or deleted. Being a single file we also have no concurrency support either.

    Also if the setup process fails at any step it should erase any files/databases created up to that point. (Edit: Filed as #114)

  2. edg2s commented on Sep 17, 2020

    @edg2s
    CollaboratorAuthor

    Being a single file we also have no concurrency support either.

    I think the only way to fix the properly would be to use a real database, maybe SQLite?

  3. added 7 commits that reference this issue on Jan 22, 2021
    42bea76
    a7db19d
    36fec5b
    a01c731
    bef9ccb
    e812cf2
    d09cf6a
  4. added 8 commits that reference this issue on Feb 1, 2021
    f47a9c0
    a6a0b88
    747e466
    3a84972
    5eef212
    651d60c
    a4149b6
    a0e70a0
  5. added a commit that references this issue on Feb 3, 2021
    7207e9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions