You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 23, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 23, 2023. It is now read-only.
Parsoid not working when building wiki with 1.38.0-wmf.1 #418
There is no wmf/1.38.0-wmf.1 branch in the mediawiki/services/parsoid repo, so it is not checked out, so we should be using Parsoid via Composer instead. I guess that doesn't work for some reason.
The dependency on the master branch should be to "wikimedia/parsoid": "^0.15.0-a1@alpha" which will be the most recent released version of parsoid. But we don't maintain backward compatibility to old wmf.1 branches. You probably want to checkout mediawiki-vendor for wmf/1.38.0-wmf.1 and use the packages from there. Looking at that branch, if appears parsoid 0.14.0-a19 is the one to use -- we were a little late cutting out 0.15 branch and the first wmf.1 snuck out with a 0.14 build.
Activity
MatmaRex commentedon Jan 25, 2022
It should be responding with HTML here: https://patchdemo.wmflabs.org/wikis/8eae561eea/w/rest.php/v1/page/Main_Page/html
…But instead I see:
MatmaRex commentedon Jan 25, 2022
There is no
wmf/1.38.0-wmf.1branch in themediawiki/services/parsoidrepo, so it is not checked out, so we should be using Parsoid via Composer instead. I guess that doesn't work for some reason.MatmaRex commentedon Jan 26, 2022
I don't know why and I'm not particularly thrilled to investigate…
edg2s commentedon Jan 26, 2022
CC @cscott
cscott commentedon Jan 26, 2022
The dependency on the master branch should be to
"wikimedia/parsoid": "^0.15.0-a1@alpha"which will be the most recent released version of parsoid. But we don't maintain backward compatibility to old wmf.1 branches. You probably want to checkout mediawiki-vendor for wmf/1.38.0-wmf.1 and use the packages from there. Looking at that branch, if appearsparsoid 0.14.0-a19is the one to use -- we were a little late cutting out 0.15 branch and the first wmf.1 snuck out with a 0.14 build.edg2s commentedon Jan 26, 2022
Sounds like this might just be a one off with this particular branch then? If that's the case then I'm fine with ignoring it..