Repository navigation
fix(ci): run Node.js 22 and 24 tests on release pull requests - #11191
Merged
Merged
Conversation
The `Test (22.x)` and `Test (24.x)` jobs only ran when `github.ref_name` was `main` or the base ref was a release branch. Release pull requests have a `release/*` head branch and target `main`, so neither condition matched and the jobs were skipped. Add a `github.head_ref` check so the full Node.js matrix runs for release pull requests.
GuillaumeRx
approved these changes
Oct 29, 2026
Mrtenz
enabled auto-merge
October 29, 2026 09:43
Merged
1 task done
Naz-Ovh
pushed a commit
to 0x-fork/metamask-core
that referenced
this pull request
Nov 4, 2026
## Explanation Re-lands the release that was reverted in MetaMask#11187 (the revert happened because CI on main was broken; the CI issue has since been fixed via MetaMask#11191, and Release/1375.0.0 was subsequently shipped by another team in MetaMask#11192, so this release is now **Release/1376.0.0**). To avoid cutting two separate releases, this PR also folds in the `@metamask/profile-controller` patch release that was staged in MetaMask#11197 (that PR is now redundant and closed in favor of this one). Two packages are released: **`@metamask/assets-controller` 20.0.2 (patch)** — 20.0.2 was never published to npm, so this re-release is safe. - **Fixed:** hand-rolled Multicall3 `aggregate3` codecs for balance batches (MetaMask#11078) **`@metamask/profile-controller` 1.2.1 (patch)** - **Added:** `clearState` method on `ProfileController` (MetaMask#11177) - **Changed:** bump `@metamask/utils` from `^12.0.0` to `^12.0.1` (MetaMask#11107) - **Fixed:** `ProfileService.disconnectX` now calls `DELETE profiles/x/account` instead of the non-existent `DELETE profiles/{profileId}/x` endpoint, since the linked X account is resolved server-side from the verified bearer token (MetaMask#11195) All functional changes above are already merged on `main`; this diff contains only version bumps and changelog finalization (plus a merge of `main` to pick up MetaMask#11195). - `@metamask/bridge-controller` and `@metamask/transaction-pay-controller` only have their `@metamask/assets-controller` dependency range bumped to `^20.0.2`; they are intentionally not released. ## Checklist - [x] `yarn changelog:validate` passes
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
Test (22.x)andTest (24.x)jobs only ran whengithub.ref_namewasmain, or when the base ref was a release branch. Release pull requests have arelease/*head branch and targetmain, so neither condition matched and the jobs were skipped (e.g., #11176 only ran the Node.js 26.x tests). This adds agithub.head_refcheck so the full Node.js matrix runs for release pull requests. Thebase_refchecks stay, as they cover pull requests that target a release branch.References
Checklist
Note
Low Risk
Workflow-only change to job
ifconditions; no application code or runtime behavior is affected.Overview
Test (22.x) and Test (24.x) in
lint-build-test.ymlnow run when the pull request head branch isrelease/*, not only onmainor when the base is a release branch.Release PRs (
release/*→main) previously skipped those jobs becausegithub.ref_nameis the head branch and the old conditions did not treat a release head as eligible—so only Node 26.x tests ran. The existingbase_ref/ merge-group release checks are unchanged for PRs targeting release branches.Reviewed by Cursor Bugbot for commit adf8b64. Bugbot is set up for automated code reviews on this repo. Configure here.