Repository navigation
fix: pin Cubist escrow C2F to v10 - #11347
Draft
huggingbot wants to merge 2 commits into
Draft
huggingbot wants to merge 2 commits into
huggingbot wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Pin
CubistEscrowProvider's default C2F version tov10(cubist-secret-escrow release 0.1.0) instead of the movinglatestalias so recovery operations consistently invoke the intended escrow release.versionoption for callers that explicitly select another version.References
Validation
@metamask/mfa-recovery-controllersuite: 203 tests across 6 files.yarn exec tsc --project packages/mfa-recovery-controller/tsconfig.lint.json --noEmit.yarn changelog:validate:all.yarn exec tsc --build packages/mfa-recovery-controller/tsconfig.lint.json) reports unrelated errors in dependency test files, includingjson-rpc-engine,keyring-controller,geolocation-controller,remote-feature-flag-controller, andprofile-sync-controller.Checklist